Skip to content

Use eslint v9. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 22, 2025
Merged

Use eslint v9. #122

merged 7 commits into from
Sep 22, 2025

Conversation

davidlehn
Copy link
Member

@davidlehn
Update to eslint@9.
1c10686 
- Update dependencies.
- Update config files.
@davidlehn
Fix lint issues.
dae4bd5
@davidlehn davidlehn requested a review from jameseaster August 9, 2025 00:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.04%. Comparing base (c8b9077) to head (9715e77).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   12.04%   12.04%           
=======================================
  Files           6        6           
  Lines          83       83           
=======================================
  Hits           10       10           
  Misses         73       73
Files with missing lines Coverage Δ
lib/cardDesigns.js 100.00% <ø> (ø)
lib/router.js 3.38% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b9077...9715e77. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jameseaster
jameseaster approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@jameseaster jameseaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I ran this locally, issued four credentials, and the wallet worked well.

@jameseaster
Copy link
Contributor

This might be a good time to add the no trailing comma to the eslint rules. It will add more consistency in future contributions

@davidlehn davidlehn mentioned this pull request Aug 11, 2025
Closed
@davidlehn davidlehn marked this pull request as ready for review September 2, 2025 23:34
@davidlehn davidlehn requested a review from dlongley September 2, 2025 23:34
@davidlehn davidlehn merged commit 5f6da51 into main Sep 22, 2025
3 checks passed
@davidlehn davidlehn deleted the use-eslint-v9 branch September 22, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@jameseaster jameseaster jameseaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidlehn @codecov-commenter @jameseaster @dlongley