Skip to content

Use eslint v9. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .eslintrc.cjs

This file was deleted.

8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# bedrock-vue-wallet ChangeLog

## 29.5.2 - 2025-08-xx

### Changed
- Update to `eslint@9`.

### Fixed
- Fix lint issues.

## 29.5.1 - 2024-10-24

### Fixed
Expand Down
1 change: 0 additions & 1 deletion components/AccessManagement.vue
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ export default {
props: {
profileId: {
type: String,
default: '',
required: true
}
},
Expand Down
1 change: 0 additions & 1 deletion components/AddProfileModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export default {
},
profileOptions: {
type: Array,
default: () => [],
required: true
}
},
Expand Down
1 change: 0 additions & 1 deletion components/CapabilitiesList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export default {
name: 'CapabilitiesList',
props: {
capabilities: {
default: () => [],
type: Array,
required: true
}
Expand Down
4 changes: 1 addition & 3 deletions components/CredentialDashboard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export default {
},
props: {
credentials: {
default: () => [],
type: Array,
required: true
},
Expand All @@ -77,7 +76,6 @@ export default {
required: false
},
errorText: {
default: '',
type: String,
required: true
}
Expand Down Expand Up @@ -139,7 +137,7 @@ export default {

// Watchers
watch(() => filteredProfiles, () => {
return emit('filtered-profiles', filteredProfiles);
return emit('filtered-profiles', filteredProfiles.value);
}, {immediate: true});

// Get each credential title and subtitle overrides
Expand Down
1 change: 0 additions & 1 deletion components/CredentialsList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ export default {
},
props: {
credentials: {
default: () => [],
type: Array,
required: true
},
Expand Down
4 changes: 2 additions & 2 deletions components/NfcShare.vue
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ export default {
// receives the VPR
const dec = new TextDecoder();
try {
// eslint-disable-next-line max-len
if(event && event.message && event.message.records && event.message.records[0] && event.message.records[0].data) {
if(event && event.message && event.message.records &&
event.message.records[0] && event.message.records[0].data) {
const vpr = JSON.parse(dec.decode(event.message.records[0].data));
console.log('NFC read event:', event);
console.log('VPR received:', vpr);
Expand Down
9 changes: 3 additions & 6 deletions components/ProblemCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,15 @@ export default {
props: {
account: {
type: String,
required: true,
default: ''
required: true
},
error: {
type: Error,
required: true,
default: undefined
required: true
},
loading: {
type: Boolean,
required: true,
default: true
required: true
}
},
emits: ['cancel'],
Expand Down
2 changes: 0 additions & 2 deletions components/ProfileChooser.vue
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,10 @@ export default {
props: {
loading: {
type: Boolean,
default: true,
required: true
},
profiles: {
type: Array,
default: () => [],
required: true
},
selected: {
Expand Down
1 change: 0 additions & 1 deletion components/ProfileForm.vue
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ export default {
},
profileOptions: {
type: Array,
default: () => [],
required: true
}
},
Expand Down
1 change: 0 additions & 1 deletion components/RegisterForm.vue
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ export default {
// registration now complete
await this.$emitExtendable('register');
} catch(e) {
// eslint-disable-line no-console
console.error('Register Error', e);
const newError = `${e.name}: ${e.message || 'No Message'}`;
this.error = newError;
Expand Down
6 changes: 2 additions & 4 deletions components/ShareCredentials.vue
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,11 @@ export default {
props: {
requestOrigin: {
type: String,
required: true,
default: ''
required: true
},
verifiablePresentationRequest: {
type: [Object, Array],
required: true,
default: () => ({})
required: true
}
},
emits: ['share', 'cancel'],
Expand Down
15 changes: 5 additions & 10 deletions components/ShareReview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -67,28 +67,23 @@ export default {
props: {
authentication: {
type: Boolean,
required: true,
default: () => false
required: true
},
capabilities: {
type: Array,
required: true,
default: () => []
required: true
},
credentials: {
type: Array,
required: true,
default: () => []
required: true
},
loading: {
type: Boolean,
required: true,
default: true
required: true
},
requestOrigin: {
type: String,
required: true,
default: ''
required: true
}
}
};
Expand Down
7 changes: 2 additions & 5 deletions components/StoreCredentials.vue
Original file line number Diff line number Diff line change
Expand Up @@ -82,18 +82,15 @@ export default {
props: {
account: {
type: String,
required: true,
default: ''
required: true
},
verifiableCredential: {
type: Array,
default: () => [],
required: true
},
holder: {
type: String,
required: true,
default: ''
required: true
}
},
emits: ['store', 'cancel'],
Expand Down
38 changes: 38 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import globals from 'globals';

import digitalbazaar from 'eslint-config-digitalbazaar';
import digitalbazaarJsdoc from 'eslint-config-digitalbazaar/jsdoc';
import digitalbazaarModule from 'eslint-config-digitalbazaar/module';
import digitalbazaarVue3 from 'eslint-config-digitalbazaar/vue3';

export default [
{
ignores: ['**/node_modules/']
},
// not yet supported
// 'plugin:quasar/standard'
...digitalbazaar,
...digitalbazaarJsdoc,
...digitalbazaarModule,
...digitalbazaarVue3,
{
files: [
'**/*.js'
],
languageOptions: {
globals: {
...globals.browser
}
}
},
{
files: [
'test/web/**/*.js'
],
languageOptions: {
globals: {
...globals.mocha
}
}
}
];
1 change: 0 additions & 1 deletion lib/cardDesigns.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
export const cardDesigns = [
{
matches: {
// eslint-disable-next-line max-len
'/@context': 'https://contexts.vcplayground.org/examples/food-safety-certification/v1.json',
'/type': 'FoodSafetyCertificationCredential'
},
Expand Down
1 change: 0 additions & 1 deletion lib/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export async function addWalletToChapi({} = {}) {
}
} catch(e) {
if(e.message !== 'Permission denied.') {
// eslint-disable-line no-console
console.error('CHAPI register error:', e);
}
Notify.create({
Expand Down
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"routes/*"
],
"scripts": {
"lint": "eslint --ext .cjs,.js,.vue ."
"lint": "eslint"
},
"dependencies": {
"@digitalbazaar/http-client": "^4.1.1",
Expand Down Expand Up @@ -45,13 +45,13 @@
"vue-router": "^4.3.0"
},
"devDependencies": {
"eslint": "^8.57.0",
"eslint-config-digitalbazaar": "^5.0.1",
"eslint-plugin-jsdoc": "^50.4.1",
"eslint-plugin-quasar": "^1.1.0",
"eslint-plugin-vue": "^9.23.0",
"jsdoc": "^4.0.2",
"jsdoc-to-markdown": "^9.0.2"
"eslint": "^9.33.0",
"eslint-config-digitalbazaar": "github:digitalbazaar/eslint-config-digitalbazaar#use-eslint-v9",
"eslint-plugin-jsdoc": "^52.0.4",
"eslint-plugin-unicorn": "^60.0.0",
"eslint-plugin-vue": "^10.4.0",
"globals": "^16.3.0",
"vue-eslint-parser": "^10.2.0"
},
"engines": {
"node": ">=18"
Expand Down
1 change: 0 additions & 1 deletion routes/RegisterPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export default {
router.push({name: 'home'});
} catch(e) {
const newError = `${e.name}: ${e.message || 'No Message'}`;
// eslint-disable-line no-console
console.error('Register Error:', e);
$q.notify({
type: 'negative',
Expand Down
6 changes: 0 additions & 6 deletions test/.eslintrc.cjs

This file was deleted.

10 changes: 0 additions & 10 deletions test/web/.eslintrc.cjs

This file was deleted.