Skip to content

Recommend eslint v8 in README. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

BigBlueHat
Copy link
Contributor

Avoiding lack of eslint v9 support per #73.

@BigBlueHat BigBlueHat requested review from davidlehn and tminard April 8, 2024 15:58
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try just doing

npm i -D eslint-config-digitalbazaar? npm will just install the eslint for the peerDep for you now unless there is an existing config issue. so might be able to drop npm i -D eslint from the README entirely.

Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but was not tested alot. @BigBlueHat this merges my changes into your branch.

@davidlehn
Copy link
Member

npm, npx, and peerdep instructions are getting a bit complex. Can this say that eslint v8 is required and leave it at that? The npx eslint --init command also needs to be pinned to v8 now too.

@BigBlueHat
Copy link
Contributor Author

Here's what I just had to do in a new repo to get things to work:

$ npm i -D eslint@8 # I started here...no idea if I could have skipped it...
$ npm i -D eslint-config-digitalbazaar
$ npm i -D eslint-plugin-unicorn # per error messages
$ npm i -D eslint-plugin-jsdoc # per more errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants