Fix _removeDotSegments. #193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix _removeDotSegments logic to pass all the json-ld.org RFC3986 tests.
Member
Author
|
Will likely hold off on merging this and work on a fix that also handles the current tests that don't remove dot segments from base URIs. It's also been noted this perhaps should be a minor bump since the outputs could change if these edge case URIs were used as input, even though it's due to a buggy implementation. |
Fixes various RFC3986 tests with dot segments in the base path.
After code updates the hasAuthority paramter is no longer used.
Member
Author
|
@dlongley Please re-review. Thanks. |
Member
Author
|
Note, this now passes all RFC3986 tests as is. |
dlongley
approved these changes
Jul 25, 2017
Member
dlongley
left a comment
dlongley
left a comment
There was a problem hiding this comment.
Still LGTM if it's passing tests. Still a breaking change.
Member
|
Note: also needs to be ported to 0.5.x if not already. |
Member
Author
|
Fixed via other commits and released in 0.5.17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix _removeDotSegments logic to pass all the json-ld.org RFC3986 tests.
Oddly this doesn't require the use of the hasAuthority parameter. Is this just luck with the current json-ld.org test cases or is there an edge case where this would fail?
This patch requires json-ld/json-ld.org#525 to fully pass the tests.