Skip to content

Adjust promotion message - #962

Open
f1sh1918 wants to merge 1 commit into
mainfrom
adjust-promotion-message
Open

Adjust promotion message#962
f1sh1918 wants to merge 1 commit into
mainfrom
adjust-promotion-message

Conversation

@f1sh1918

@f1sh1918 f1sh1918 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Short description

Currently the release message for the beta and promotion message for the production delivery aber equal and it

Proposed changes

  • clarify for promotion that the release has been promoted to production

How to test

  • N/A

Resolved issues

Fixes: #

@f1sh1918 f1sh1918 added the maintenance for non user facing changes label Aug 24, 2026
@deliverino

deliverino Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

LLM Review (verdigado-think)

Commit message style
The commit message adjust-promotion-message does not follow the repository convention. It is missing the <ticket-number-or-branch-slug>: prefix (e.g., adjust-promotion-message: update mattermost notification text).

@LeandraH LeandraH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😊

command: |
NEW_VERSION=$(jq -r .versionName version.json)
MESSAGE="##### Lunes CMS version [${NEW_VERSION}](https://github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/releases/tag/${NEW_VERSION}) has been released successfully :tada:"
MESSAGE="##### Lunes CMS version [${NEW_VERSION}](https://github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/releases/tag/${NEW_VERSION}) has been promoted successfully to production and will be available within the next hours :tada:"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, within the next hours is only accurate if someone runs a highstate manually. Otherwise the new version will be available after the automatic high state on Friday morning, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but actually according to our release workflow it should be done by a dev.
If there are any breaks on friday after highstate likely no people are here to fix that.
So for me that friday routine is just a fallback but feel free to suggest a better wording

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MESSAGE="##### Lunes CMS version [${NEW_VERSION}](https://github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/releases/tag/${NEW_VERSION}) has been promoted successfully to production and will be available within the next hours :tada:"
MESSAGE="##### Lunes CMS version [${NEW_VERSION}](https://github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/releases/tag/${NEW_VERSION}) has been promoted successfully to production :tada:"$'\n'"It goes live on lunes-prod with the next highstate – please run it to complete the release."

How about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance for non user facing changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants