Add SwapDigraphs and DigraphsRemoveAllEdges functions
#864
+134
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtorpey
previously requested changes
Oct 1, 2025
wilfwilson
changed the title
SwapDigraphs and DigraphsRemoveAllEdges functions
james-d-mitchell
requested changes
Oct 7, 2025
mtorpey
dismissed
their stale review
Mostly fixed, with remaining problems covered by @james-d-mitchell's review.
mtorpey
reviewed
Oct 8, 2025
mtorpey
reviewed
Oct 8, 2025
mtorpey
reviewed
Oct 8, 2025
mtorpey
requested changes
Oct 9, 2025
| <Attr Name="DigraphRemoveAllEdgesAttr" Arg="digraph"/> | ||
| <Returns>An empty digraph.</Returns> | ||
| <Description> | ||
| This operation returns a digraph constructed from <A>digraph</A>, which is mutable, |
There was a problem hiding this comment.
"which is mutable" is out of date – it might not be mutable, as you've explained below.
There was a problem hiding this comment.
A sentence including the word "if" would be better. :)
| end); | ||
|
|
||
| InstallMethod(SwapDigraphs, | ||
| "for a mutable digraph and mutable digraph", |
There was a problem hiding this comment.
Better would be "for two mutable digraphs".
| <mutable digraph with 3 vertices, 3 edges> | ||
| gap> DigraphRemoveAllEdges(D3); | ||
| <mutable empty digraph with 3 vertices> | ||
| true |
There was a problem hiding this comment.
I'm not sure where "true" came from. Is this included by accident? I'm surprised it passes the tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created
SwapDigraphsto swap the contents of two digraphs, and addedDigraphsRemoveAllEdgesfor removing all edges from a digraph