Skip to content

Make secrets.json not being found an explicit error when DJANGOPROJECT_DATA_DIR is set #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make secrets.json not being found an explicit error when DJANGOPROJECT_DATA_DIR is set #2097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions djangoproject/settings/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,8 @@
Path(os.environ[data_dir_key]) if data_dir_key in os.environ else BASE_DIR.parent
)

try:
with DATA_DIR.joinpath("conf", "secrets.json").open() as handle:
SECRETS = json.load(handle)
except OSError:
SECRETS = {
"secret_key": "a",
"superfeedr_creds": ["[email protected]", "some_string"],
}

with DATA_DIR.joinpath("conf", "secrets.json").open() as handle:
SECRETS = json.load(handle)

# Django settings

Expand Down