-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add link to 'Stable' doc version in the Warning Alert on top #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8896bd3
to
44aa2df
Compare
Thanks for pushing this PR! Since the main logic is in place and you're open to someone continuing the work, I'd love to take it forward and handle the remaining styling updates. |
@SomeAB @sabderemane Do you have any recommendations for styling? I think the default styling for this link looks a bit weird, but I'm not sure what would be the correct way. |
|
@ulgens Please feel free to ping me on discord or here. I'm more active on discord. Sorry for the delay in reply A. Regarding the wording: I would personally recommend: "Please click here for the stable version" Rationale: saying 'stable' instead of 'latest' is more inline with the previous sentence, which points at the depreciation of the doc version currently being viewed. Implicitly, we are recommending the latest LTS (link should point to LTS version given its long term support) Two ways of highlighting: B. Regarding Color: I agree with SaptakS here, that making it as the same color (dark) is preferable. Rationale: Given the Django website uses an unusual combo of peach-pink with leaf-green, introducing new colors would just stick out badly. The highlight is suppose to be just a small nudge .. just enough to tell that it is clickable Preview of two versions:
|
I agree with Saptak for the styling and the wording. The wording "Please check the latest version.", with the "latest version" anchor linked is better. |
Resolves #2094
I copied the link from "Installation guide" link on the sidebar, please let me know if we prefer a different target for the link.
I'm open to suggestions about wording and styling.