-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Updates minutes links #2221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updates minutes links #2221
Conversation
The new link points to the new minutes repo. Also updated the tests related to it.
413dfca
to
21fbaa5
Compare
@CaptainJack2491 thanks for contributing! However there is already #2111 and #2085 which are actively being worked on to fix this issue. Hence, I am going to close this PR as duplicate and request you to look into other open issues which are not currently being worked on. |
After discussion with @knyghty and knowing that this PR is being worked on in the PyCon UK sprint, I am reopening it. I would appreciate taking a look at the work done in the other PRs. |
The tests need to be rewritten to not use Meetings.
have also added migrations
for more information, see https://pre-commit.ci
ba76320
to
63e9bf5
Compare
The old URLs still need to be re-directed. |
I will work on the redirects stuff, do a quick check there's no extra straggling stuff to delete, and let you know when I'm done. Hopefully this week! |
Add redirects for old minutes
for more information, see https://pre-commit.ci
I think it's good though the workflow needs approving again now. @bmispelon probably good for you to review since you suggested tearing everything out and adding the redirects. |
fixes #2079
The new link points to the new minutes repo. Also updated the tests related to it.