Skip to content

Added django-storages[boto3] dependency for S3 support - #2851

Merged
sabderemane merged 1 commit into
django:mainfrom
saikat709:add_django_storages_deps
Oct 8, 2026
Merged

sabderemane merged 1 commit into
django:mainfrom
saikat709:add_django_storages_deps

Conversation

@saikat709

Copy link
Copy Markdown
Contributor

Added django-storages[boto3]==1.14.6 to production dependencies.

This dependency is needed for PR #2844 (Added optional django-storages (S3) support for media) which refers to issue #2802.

AI Assistance Disclosure (REQUIRED)

  • No AI tools were used in preparing this PR.
  • If AI tools were used, I have disclosed which ones and fully reviewed and verified their output.

@ulgens
ulgens requested review from a team September 16, 2026 14:54

@tobiasmcnulty tobiasmcnulty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@901dd6b). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2851   +/-   ##
=======================================
  Coverage        ?   87.99%           
=======================================
  Files           ?      199           
  Lines           ?     7513           
  Branches        ?      407           
=======================================
  Hits            ?     6611           
  Misses          ?      815           
  Partials        ?       87           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ulgens

ulgens commented Sep 24, 2026

Copy link
Copy Markdown
Member

@django/django-website-mergers Can we have a rebase merge to keep it clean?

@sabderemane
sabderemane force-pushed the add_django_storages_deps branch from fc35de0 to 27671ce Compare October 8, 2026 01:13
@sabderemane
sabderemane merged commit 0356d3d into django:main Oct 8, 2026
@saikat709
saikat709 deleted the add_django_storages_deps branch October 8, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants