Skip to content

add Apple operating system version #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

add Apple operating system version #4253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec/version.dd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,11 @@ $(H3 $(LEGACY_LNAME2 PredefinedVersions, predefined-versions, Predefined Version
$(TROW $(ARGS $(D SDC)) , $(ARGS SDC (Snazzy D Compiler)))

$(TROW *Target Operating System*)
$(TROW $(ARGS $(D Windows)) , $(ARGS Microsoft Windows systems))
$(TROW $(ARGS $(D Windows)) , $(ARGS Microsoft Windows systems Win32 and Win64))
$(TROW $(ARGS $(D Win32)) , $(ARGS Microsoft 32-bit Windows systems))
$(TROW $(ARGS $(D Win64)) , $(ARGS Microsoft 64-bit Windows systems))
$(TROW $(ARGS $(D linux)) , $(ARGS All Linux systems))
$(TROW $(ARGS $(D Apple)) , $(ARGS Apple systems OSX, iOS, TVOS, WatchOs and VisionOS))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's supposed to be WatchOS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if we want these to list the OSes by their current name rather than the version identifiers, then it should arguably be macOS instead of OSX like it currently says next to the description for the OSX version identifier. Though I don't really care much personally.

Aside from the typo, I'd merge this right now, but the dmd one hasn't been merged, and I don't know if I should be making that kind of call for dmd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe here should be:

$(TROW $(ARGS $(D Apple)) , $(ARGS Apple systems $(D OSX), $(D iOS), $(D TVOS), $(D WatchOS) and $(D VisionOS)))

As in the description after 'systems' some version identifiers are mentioned.
Same is relevant for row about Windows:

$(TROW $(ARGS $(D Windows)) , $(ARGS Microsoft Windows systems $(D Win32) and $(D Win64)))

$(TROW $(ARGS $(D OSX)) , $(ARGS macOS))
$(TROW $(ARGS $(D iOS)) , $(ARGS iOS))
$(TROW $(ARGS $(D TVOS)) , $(ARGS tvOS))
Expand Down