-
-
Notifications
You must be signed in to change notification settings - Fork 650
Packagise the glue layer intoirgen/
#21572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21572" |
Gluelayer shouldn't be moved. If it's not longer imported by any front-end modules, then just delete it. |
codegen? Pedantically speaking, the bit between the front-end and back-end is called the middle-end, though dmd never made use of one. :-) |
a8f347f
to
03d7788
Compare
03d7788
to
e574f16
Compare
I like names to be stable, distinct, descriptive, and short. While "glue" is not self-evident, I think it is descriptive enough for 'glueing' the frontend and backend together. Any change of name will for sure sacrifice 'stable', and I can't find anything more descriptive without becoming very long or less distinct. 'codegen' is a name I'd also use to describe the x86/arm backend for example. |
Serg suggested |
525e482
to
767b4fa
Compare
767b4fa
to
c121dac
Compare
irgen/
@dkorpel Ready to go |
I'm afraid this causes merge conflicts for #21066, so perhaps we can wait with merging this as to not put more work on @rainers's plate. I'm also not a fan of the name change, several references to the glue layer have already been made in past talks/documentation, I don't think it's worth breaking that for |
I don't really like the name "glue", if you have abetter name, now is the time to speak up.