Skip to content

Packagise the glue layer intoirgen/ #21572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thewilsonator
Copy link
Contributor

@thewilsonator thewilsonator commented Jul 21, 2025

I don't really like the name "glue", if you have abetter name, now is the time to speak up.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21572"

@ibuclaw
Copy link
Member

ibuclaw commented Jul 21, 2025

Gluelayer shouldn't be moved. If it's not longer imported by any front-end modules, then just delete it.

@ibuclaw
Copy link
Member

ibuclaw commented Jul 21, 2025

I don't really like the name "glue", if you have abetter name, now is the time to speak up.

codegen?

Pedantically speaking, the bit between the front-end and back-end is called the middle-end, though dmd never made use of one. :-)

@thewilsonator thewilsonator force-pushed the glue-package branch 13 times, most recently from a8f347f to 03d7788 Compare July 23, 2025 03:04
@thewilsonator thewilsonator marked this pull request as ready for review July 23, 2025 03:55
@dkorpel
Copy link
Contributor

dkorpel commented Jul 23, 2025

I don't really like the name "glue", if you have abetter name, now is the time to speak up.

I like names to be stable, distinct, descriptive, and short. While "glue" is not self-evident, I think it is descriptive enough for 'glueing' the frontend and backend together. Any change of name will for sure sacrifice 'stable', and I can't find anything more descriptive without becoming very long or less distinct. 'codegen' is a name I'd also use to describe the x86/arm backend for example.

@thewilsonator
Copy link
Contributor Author

Serg suggested irgen which I am partial to.

@thewilsonator thewilsonator force-pushed the glue-package branch 6 times, most recently from 525e482 to 767b4fa Compare July 24, 2025 11:15
@thewilsonator thewilsonator changed the title Packagise the glue layer Packagise the glue layer intoirgen/ Jul 24, 2025
@thewilsonator
Copy link
Contributor Author

@dkorpel Ready to go

@dkorpel
Copy link
Contributor

dkorpel commented Jul 24, 2025

I'm afraid this causes merge conflicts for #21066, so perhaps we can wait with merging this as to not put more work on @rainers's plate.

I'm also not a fan of the name change, several references to the glue layer have already been made in past talks/documentation, I don't think it's worth breaking that for irgen which is just barely more self-evident. If Walter approves, I'd be okay with it though.

@thewilsonator
Copy link
Contributor Author

I'm afraid this causes merge conflicts for #21066, so perhaps we can wait with merging this as to not put more work on @rainers's plate.

That's fine by me, there is no great rush here. I'm going to have to resolve the current conflicts at some point anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants