Feat: Type hints in Hubspot source #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

anuunchin merged 2 commits into master from fix/hubspot

Aug 21, 2025

Collaborator

anuunchin commented Aug 13, 2025 •

edited

Loading

This PR adds type hints to Hubspot sources. This was needed because the Hubspot API returns strings for columns that are marked as "number" columns in Hubspot, which results in dlt inferring the data type as "text".

A corresponding test with a minimal example is added.
The mapping from hubspot types to dlt types is added to the settings file, so that it's easier to adjust for additional types in the future.

This PR resolves #635

anuunchin self-assigned this

anuunchin force-pushed the fix/hubspot branch from 94dc1d6 to 6a7391d Compare

August 13, 2025 07:32

anuunchin changed the title ~~Feat: Type hints in Hubspot source~~ Feat: Type hints, property param chunking in Hubspot source

anuunchin force-pushed the fix/hubspot branch from 6a7391d to 887d30a Compare

August 13, 2025 07:53

anuunchin changed the title ~~Feat: Type hints, property param chunking in Hubspot source~~ Feat: Type hints in Hubspot source

anuunchin force-pushed the fix/hubspot branch 3 times, most recently from 45a877c to 521181a Compare

August 13, 2025 08:11

anuunchin requested a review from djudjuu

August 13, 2025 08:28

djudjuu reviewed

View reviewed changes

tests/hubspot/mock_data.py Outdated Show resolved Hide resolved

djudjuu reviewed

View reviewed changes

tests/hubspot/test_hubspot_source.py Show resolved Hide resolved

djudjuu reviewed

View reviewed changes

sources/hubspot_pipeline.py Outdated Show resolved Hide resolved

djudjuu reviewed

View reviewed changes

sources/hubspot/__init__.py Outdated Show resolved Hide resolved

djudjuu reviewed

View reviewed changes

sources/hubspot/__init__.py Show resolved Hide resolved

djudjuu previously approved these changes

View reviewed changes

Contributor

djudjuu left a comment

that is good stuff! just one doc-string that needs updating and some imports that can be removed. you can merge afterwards

anuunchin dismissed djudjuu’s stale review via

37e38b0

August 20, 2025 12:04

anuunchin force-pushed the fix/hubspot branch 2 times, most recently from 2cf97b0 to 9a65ca3 Compare

August 20, 2025 12:11

anuunchin added 2 commits

August 20, 2025 14:19


          Type hints in Hubspot source

e868a9b


          Unused types from hubspot mock data removed, better handling of hints

fe94a6a

anuunchin force-pushed the fix/hubspot branch from 9a65ca3 to fe94a6a Compare

August 20, 2025 12:19

anuunchin requested a review from djudjuu

August 21, 2025 08:10

djudjuu approved these changes

View reviewed changes

anuunchin merged commit d4b1e3a into master

15 checks passed

erummel mentioned this pull request

Get all HubSpot properties #600

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet