-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
optimize CPU inference with Array-Based Tree Traversal #11519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trivialfis
merged 44 commits into
dmlc:master
from
razdoburdin:dev/cpu/eytzinger_layout
Sep 10, 2025
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
e64e20c
basic implementation
60c2ffe
optimisations
8f6dfe3
fix compilation error
bd13491
perf optimzation
3827a49
add categorial
7334bd2
add multitarget
8356855
linting
165b34a
perf
52eee0c
fix perf
cb28530
refactoring
7ae3a42
add comments
2799644
more comments
a8bb91e
fix and tildy
6d94176
Update src/predictor/array_tree_layout.h
razdoburdin e34becc
add static assertions
a2f2c75
fix randome state usage in sycl training_continuation test
2afad25
Merge branch 'master' into dev/cpu/eytzinger_layout
razdoburdin 92ac69e
check if right child is valid
e2b0f05
Merge branch 'dev/cpu/eytzinger_layout' of https://github.com/razdobu…
87bee15
use signed ints for node indxes
c3c1c85
Update src/predictor/array_tree_layout.h
razdoburdin d270ee7
Update src/predictor/array_tree_layout.h
razdoburdin 2a7e575
Update src/predictor/array_tree_layout.h
razdoburdin 3539ec0
Update src/predictor/array_tree_layout.h
razdoburdin 709d233
Update src/predictor/array_tree_layout.h
razdoburdin 40be7e2
Update src/predictor/array_tree_layout.h
razdoburdin c9160c6
Update src/predictor/cpu_predictor.cc
razdoburdin de552e8
linting
9c1007f
add tests
92b5069
lint
b0eaa85
Update src/predictor/cpu_predictor.cc
razdoburdin 790a98e
Merge branch 'master' into dev/cpu/eytzinger_layout
razdoburdin 89e56b7
Update src/predictor/array_tree_layout.h
razdoburdin 2f88dce
Inplace predict always use block.
trivialfis bcbb223
Merge branch 'master' into dev/cpu/eytzinger_layout
bb322c6
merge master
32ed633
clean up
0269d3c
clean up
13b2011
fix
6d26173
include <array>
8b89b91
remove overloading
db37a3c
Small cleanup.
trivialfis d7cf260
Cleanup inline.
trivialfis b8cd8c0
comments.
trivialfis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,226 @@ | ||
/** | ||
* Copyright 2021-2025, XGBoost Contributors | ||
* \file array_tree_layout.cc | ||
* \brief Implementation of array tree layout -- a powerfull inference optimization method. | ||
*/ | ||
#ifndef XGBOOST_PREDICTOR_ARRAY_TREE_LAYOUT_H_ | ||
#define XGBOOST_PREDICTOR_ARRAY_TREE_LAYOUT_H_ | ||
|
||
#include <array> | ||
#include <limits> | ||
#include <type_traits> // for conditional_t | ||
|
||
#include "../common/categorical.h" // for IsCat | ||
#include "xgboost/tree_model.h" // for RegTree | ||
|
||
namespace xgboost::predictor { | ||
|
||
/** | ||
* @brief The class holds the array-based representation of the top levels of a single tree. | ||
* | ||
* @tparam has_categorical if the tree has categorical features | ||
* | ||
* @tparam any_missing if the class is able to process missing values | ||
* | ||
* @tparam kNumDeepLevels number of tree leveles being unrolled into array-based structure | ||
*/ | ||
template <bool has_categorical, bool any_missing, int kNumDeepLevels> | ||
class ArrayTreeLayout { | ||
private: | ||
/* Number of nodes in the array based representation of the top levels of the tree | ||
*/ | ||
constexpr static size_t kNodesCount = (1u << kNumDeepLevels) - 1; | ||
|
||
struct Empty {}; | ||
using DefaultLeftType = | ||
typename std::conditional_t<any_missing, std::array<uint8_t, kNodesCount>, Empty>; | ||
using IsCatType = | ||
typename std::conditional_t<has_categorical, std::array<uint8_t, kNodesCount>, Empty>; | ||
using CatSegmentType = | ||
typename std::conditional_t<has_categorical, | ||
std::array<common::Span<uint32_t const>, kNodesCount>, Empty>; | ||
|
||
DefaultLeftType default_left_; | ||
IsCatType is_cat_; | ||
CatSegmentType cat_segment_; | ||
|
||
std::array<bst_feature_t, kNodesCount> split_index_; | ||
std::array<float, kNodesCount> split_cond_; | ||
/* The nodes at tree levels 0, 1, ..., kNumDeepLevels - 1 are unrolled into an array-based structure. | ||
* If the tree has additional levels, this array stores the node indices of the sub-trees at level kNumDeepLevels. | ||
* This is necessary to continue processing nodes that are not eligible for array-based unrolling. | ||
* The number of sub-trees packed into this array is equal to the number of nodes at tree level kNumDeepLevels, | ||
* which is calculated as (1u << kNumDeepLevels) == kNodesCount + 1. | ||
razdoburdin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
// Mapping from array node index to the RegTree node index. | ||
std::array<bst_node_t, kNodesCount + 1> nidx_in_tree_; | ||
razdoburdin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/** | ||
* @brief Traverse the top levels of original tree and fill internal arrays | ||
* | ||
* @tparam depth the tree level being processing | ||
* | ||
* @param tree the original tree | ||
* @param cats matrix of categorical splits | ||
* @param nidx_array node idx in the array layout | ||
* @param nidx node idx in the original tree | ||
*/ | ||
template <int depth = 0> | ||
void Populate(const RegTree& tree, RegTree::CategoricalSplitMatrix const& cats, | ||
bst_node_t nidx_array = 0, bst_node_t nidx = 0) { | ||
if constexpr (depth == kNumDeepLevels + 1) { | ||
return; | ||
} else if constexpr (depth == kNumDeepLevels) { | ||
/* We store the node index in the original tree to ensure continued processing | ||
* for nodes that are not eligible for array layout optimization. | ||
*/ | ||
nidx_in_tree_[nidx_array - kNodesCount] = nidx; | ||
} else { | ||
if (tree.IsLeaf(nidx)) { | ||
split_index_[nidx_array] = 0; | ||
|
||
/* | ||
* If the tree is not fully populated, we can reduce transfer costs. | ||
* The values for the unpopulated parts of the tree are set to ensure | ||
* that any move will always proceed in the "right" direction. | ||
* This is achieved by exploiting the fact that comparisons with NaN always result in false. | ||
*/ | ||
if constexpr (any_missing) default_left_[nidx_array] = 0; | ||
if constexpr (has_categorical) is_cat_[nidx_array] = 0; | ||
split_cond_[nidx_array] = std::numeric_limits<float>::quiet_NaN(); | ||
|
||
Populate<depth + 1>(tree, cats, 2 * nidx_array + 2, nidx); | ||
} else { | ||
if constexpr (any_missing) default_left_[nidx_array] = tree.DefaultLeft(nidx); | ||
if constexpr (has_categorical) { | ||
is_cat_[nidx_array] = common::IsCat(cats.split_type, nidx); | ||
if (is_cat_[nidx_array]) { | ||
cat_segment_[nidx_array] = cats.categories.subspan(cats.node_ptr[nidx].beg, | ||
cats.node_ptr[nidx].size); | ||
} | ||
} | ||
|
||
split_index_[nidx_array] = tree.SplitIndex(nidx); | ||
split_cond_[nidx_array] = tree.SplitCond(nidx); | ||
|
||
/* | ||
* LeftChild is used to determine if a node is a leaf, so it is always a valid value. | ||
* However, RightChild can be invalid in some exotic cases. | ||
* A tree with an invalid RightChild can still be correctly processed using classical methods | ||
* if the split conditions are correct. | ||
* However, in an array layout, an invalid RightChild, even if unreachable, can lead to memory corruption. | ||
* A check should be added to prevent this. | ||
*/ | ||
Populate<depth + 1>(tree, cats, 2 * nidx_array + 1, tree.LeftChild(nidx)); | ||
bst_node_t right_child = tree.RightChild(nidx); | ||
if (right_child != RegTree::kInvalidNodeId) { | ||
Populate<depth + 1>(tree, cats, 2 * nidx_array + 2, right_child); | ||
} | ||
} | ||
} | ||
} | ||
|
||
bool GetDecision(float fvalue, bst_node_t nidx) const { | ||
if constexpr (has_categorical) { | ||
if (is_cat_[nidx]) { | ||
return common::Decision(cat_segment_[nidx], fvalue); | ||
} else { | ||
return fvalue < split_cond_[nidx]; | ||
} | ||
} else { | ||
return fvalue < split_cond_[nidx]; | ||
} | ||
} | ||
|
||
public: | ||
/* Ad-hoc value. | ||
* Increasing doesn't lead to perf gain, since bottleneck is now at gather instructions. | ||
*/ | ||
constexpr static int kMaxNumDeepLevels = 6; | ||
static_assert(kNumDeepLevels <= kMaxNumDeepLevels); | ||
|
||
ArrayTreeLayout(const RegTree& tree, RegTree::CategoricalSplitMatrix const &cats) { | ||
Populate(tree, cats); | ||
} | ||
|
||
const auto& SplitIndex() const { | ||
return split_index_; | ||
} | ||
|
||
const auto& SplitCond() const { | ||
return split_cond_; | ||
} | ||
|
||
const auto& DefaultLeft() const { | ||
return default_left_; | ||
} | ||
|
||
const auto& NidxInTree() const { | ||
return nidx_in_tree_; | ||
} | ||
|
||
/** | ||
* @brief Traverse the top levels of the tree for the entire block_size. | ||
* | ||
* In the array layout, it is organized to guarantee that if a node at the current level | ||
* has index nidx, then the node index for the left child at the next level is always | ||
* 2*nidx, and the node index for the right child at the next level is always 2*nidx+1. | ||
* This greatly improves data locality. | ||
* | ||
* @param fvec_tloc buffer holding the feature values | ||
* @param block_size size of the current block (1 < block_size <= 64) | ||
* @param p_nidx Pointer to the vector of node indexes in the original tree with size | ||
* equals to the block size. (One node per sample). The value corresponds | ||
* to the level next after kNumDeepLevels | ||
*/ | ||
void Process(common::Span<RegTree::FVec> fvec_tloc, std::size_t const block_size, | ||
bst_node_t* p_nidx) { | ||
for (int depth = 0; depth < kNumDeepLevels; ++depth) { | ||
std::size_t first_node = (1u << depth) - 1; | ||
|
||
for (std::size_t i = 0; i < block_size; ++i) { | ||
bst_node_t idx = p_nidx[i]; | ||
|
||
const auto& feat = fvec_tloc[i]; | ||
bst_feature_t split = split_index_[first_node + idx]; | ||
auto fvalue = feat.GetFvalue(split); | ||
if constexpr (any_missing) { | ||
bool go_left = feat.IsMissing(split) ? default_left_[first_node + idx] | ||
: GetDecision(fvalue, first_node + idx); | ||
p_nidx[i] = 2 * idx + !go_left; | ||
} else { | ||
p_nidx[i] = 2 * idx + !GetDecision(fvalue, first_node + idx); | ||
} | ||
} | ||
} | ||
// Remap to the original index. | ||
for (std::size_t i = 0; i < block_size; ++i) { | ||
p_nidx[i] = nidx_in_tree_[p_nidx[i]]; | ||
} | ||
} | ||
}; | ||
|
||
template <bool has_categorical, bool any_missing, int num_deep_levels = 1> | ||
void ProcessArrayTree(const RegTree& tree, RegTree::CategoricalSplitMatrix const& cats, | ||
common::Span<RegTree::FVec> fvec_tloc, std::size_t const block_size, | ||
bst_node_t* p_nidx, int tree_depth) { | ||
constexpr int kMaxNumDeepLevels = | ||
ArrayTreeLayout<has_categorical, any_missing, 0>::kMaxNumDeepLevels; | ||
|
||
// Fill the array tree, then output predicted node idx. | ||
if constexpr (num_deep_levels == kMaxNumDeepLevels) { | ||
ArrayTreeLayout<has_categorical, any_missing, num_deep_levels> buffer(tree, cats); | ||
buffer.Process(fvec_tloc, block_size, p_nidx); | ||
} else { | ||
if (tree_depth <= num_deep_levels) { | ||
ArrayTreeLayout<has_categorical, any_missing, num_deep_levels> buffer(tree, cats); | ||
buffer.Process(fvec_tloc, block_size, p_nidx); | ||
} else { | ||
ProcessArrayTree<has_categorical, any_missing, num_deep_levels + 1> | ||
(tree, cats, fvec_tloc, block_size, p_nidx, tree_depth); | ||
} | ||
} | ||
} | ||
|
||
} // namespace xgboost::predictor | ||
#endif // XGBOOST_PREDICTOR_ARRAY_TREE_LAYOUT_H_ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.