vendor: github.com/moby/moby/api, github.com/moby/moby/client master #6534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
bump_engine
branch
5 times, most recently
from
2427ef3 to
2351a29
Compare
austinvazquez
force-pushed
the
bump_engine
branch
2 times, most recently
from
25e53b0 to
7bf32ab
Compare
|
Looks like you updated / squashed things, and possibly reverted some changes we may still need; I likely won't have time to work on this Today, but in case you need the state from before you modified, I just pushed my branch as a "backup" branch in case useful; |
|
Sorry about that. Yeah the cut-over to the new network types is challenging because its in quite a few spots but also type disparity from go-connections for functions (ParsePortSpecs) we haven't updated yet. I touched up docker/go-connections#148 but not sure if it was worth the investment. Still seems to be parts that are not lining up. |
full diff: moby/moby@4ca8aed...694e30a Signed-off-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
bump_engine
branch
2 times, most recently
from
0d7b1d5 to
47e215c
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: moby/moby@4ca8aed...cfefa33
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)