Adjust a note regarding Kubernetes custom registry images with ECI. #23021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctalledo
requested review from
aevesdocker and
sarahsanders-docker
as code owners
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
area/desktop
Docker Desktop 4.44 brings in an improvement that makes a note in the docs no longer relevant. Re-word that note accordingly. The note will eventually be removed (say in 6 months once Docker Desktop 4.43 is no longer supported). Signed-off-by: Cesar Talledo <[email protected]>
ctalledo
force-pushed
the
eci-k8s-custom-registry-note
branch
from
30d4680 to
926d58c
Compare
aevesdocker
approved these changes
Jul 8, 2025
|
Hi @aevesdocker, sorry I didn't mean for this to be published in the DD docs until after DD 4.44 is released. Would the merge cause it to be published? |
aevesdocker
added a commit
that referenced
this pull request
Jul 9, 2025
…ry-note" This reverts commit 6fbd921.
aevesdocker
added a commit
that referenced
this pull request
Jul 9, 2025
|
Perfect, thanks @aevesdocker! |
sarahsanders-docker
pushed a commit
to sarahsanders-docker/docs
that referenced
this pull request
Jul 10, 2025
…-note Adjust a note regarding Kubernetes custom registry images with ECI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Do NOT merge until Docker Desktop 4.44 is released.
Description
Docker Desktop 4.44 brings in an improvement that makes a note in the docs no longer relevant. Re-word that note accordingly. The note will eventually be removed (say in 6 months once Docker Desktop 4.43 is no longer supported).
Reviews