feat(image): introduce WithCredentials* to select how pull credentials are retrieved #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
introduce a generic
credentialsFn
to retrieve credentials for pull operationoffers
WithCredentialsFromConfig
to get credentials from docker/cli config (current mechanism)this makes it possible to plug an alternative func that can resolve credentials from a TBD mechanism use by the docker/cli after cli/config cleanup (see discussion on docker/cli#6210), as storing credentials in config is not the desired way.
This mkes
legacyadapter
to convert docker/cli Config <-> go-sdk/config useless as (AFAICT) it is only used by Pull operation to retrieve username/password. Here we model this requirement as a minimal lookup method.