-
Notifications
You must be signed in to change notification settings - Fork 39
Very basic AdjFloat code generator
#233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Very basic AdjFloat code generator
#233
Conversation
dd36bfe to
5c9a778
Compare
5c9a778 to
d4cd44b
Compare
63f1a3a to
8b96da6
Compare
51636fe to
4ed0833
Compare
24df5ab to
d854085
Compare
dham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice but is the test coverage adequate for the huge list of operations that seem to be added above?
1f590b9 to
f1e51a9
Compare
f1e51a9 to
5afd925
Compare
Tests added. The new tests hit a divide-by-zero corner case in the power operator. There might be better workarounds than the one I've added (which essentially codes in SymPy), but that would probably be over-complicating things. |
|
A couple of points:
|
Use SymPy for autodiff and code generation. Not intended to be efficient -- the only nod to efficiency is the use of an LRU cache, arbitrarily set to size 256.
np.sin(AdjFloat)etc are annotated.