Skip to content

Avoid partial use of a Riesz map in TAO optimizers #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid partial use of a Riesz map in TAO optimizers #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e5f13e
TAO interface fix
jrmaddison Nov 13, 2025
624244f
Only set the gradient norm if we have set up the Riesz map elsewhere
jrmaddison Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyadjoint/optimization/tao_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def to_petsc(self, x, y):
y_i._ad_to_petsc(vec=x_sub)
else:
raise TypeError(f"Unexpected type: {type(y_i)}")
x_sub.restoreSubVector(iset, x_sub)
x.restoreSubVector(iset, x_sub)


def new_control_variable(reduced_functional, *, dual=False):
Expand Down Expand Up @@ -699,9 +699,6 @@ def objective_gradient(tao, x, g):
hessian_mat.getPythonContext().update,
H=hessian_mat, P=Pmat or hessian_mat)

Minv_mat = RieszMapMat(rf.controls, comm=comm)
tao.setGradientNorm(Minv_mat)

if problem.bounds is not None:
lbs = []
ubs = []
Expand All @@ -727,6 +724,9 @@ def objective_gradient(tao, x, g):
if tao.getType() in {PETSc.TAO.Type.LMVM, PETSc.TAO.Type.BLMVM}:
n, N = vec_interface.n, vec_interface.N

Minv_mat = RieszMapMat(rf.controls, comm=comm)
tao.setGradientNorm(Minv_mat)

class InitialHessian:
""":class:`petsc4py.PETSc.Mat` context.
"""
Expand Down