fix: typecheck and fix internal types #235
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #234
Enabled typechecking for the
.jsfiles. Honestly, it doesn't seem like the library was written with typesafety in mind. I have to make a lot of fixes.There's 2 possible/small breaking changes that I've left as TODO that can be fixed later or here depending on what solution you'd like to go with.
There's one small breaking change made in this PR needed to appease a lot of the internal types:
The
cacheproperty for these two options are now stricter (using the generics) so internally it's correctly accessing the properties.