Improve Telemetry Lesson: Replace API placeholder and add cache metrics documentation #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two key issues in the telemetry lesson that were making it difficult for workshop participants to follow along:
1. Replaced API Code Placeholder
The README.md contained a placeholder comment
// ... API call logic ...
instead of the actual working code implementation. This was error-prone and required participants to guess or look elsewhere for the complete code.Before:
After:
2. Added Complete Cache Metrics Documentation
The lesson defined
cache_hits_total
andcache_misses_total
metrics but didn't properly document or implement their usage. Added a comprehensive "Implementing Cache Metrics" section that:cache.TryGetValue()
pattern3. Enhanced Lesson Code Implementation
Updated the
GetZonesAsync
method in the lesson code to properly implement cache hit tracking:These changes make the telemetry lesson more complete and easier to follow, providing participants with working code they can copy-paste without errors.
Fixes #185.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms
curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.