Skip to content

Revert "Expand ASP.NET Framework to Core migration" #35768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jul 17, 2025

Reverts #35755


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
aspnetcore/migration/fx-to-core/areas/claimsprincipal-current.md aspnetcore/migration/fx-to-core/areas/claimsprincipal-current
aspnetcore/migration/fx-to-core/areas/http-context.md aspnetcore/migration/fx-to-core/areas/http-context
aspnetcore/migration/fx-to-core/areas/http-handlers.md aspnetcore/migration/fx-to-core/areas/http-handlers
aspnetcore/migration/fx-to-core/areas/http-modules.md aspnetcore/migration/fx-to-core/areas/http-modules
aspnetcore/migration/fx-to-core/areas/index.md aspnetcore/migration/fx-to-core/areas/index
aspnetcore/migration/fx-to-core/areas/membership.md aspnetcore/migration/fx-to-core/areas/membership
aspnetcore/migration/fx-to-core/areas/misc.md aspnetcore/migration/fx-to-core/areas/misc
aspnetcore/migration/fx-to-core/areas/webapi.md aspnetcore/migration/fx-to-core/areas/webapi
aspnetcore/migration/fx-to-core/inc/ab-testing.md aspnetcore/migration/fx-to-core/inc/ab-testing
aspnetcore/migration/fx-to-core/inc/blazor.md aspnetcore/migration/fx-to-core/inc/blazor
aspnetcore/migration/fx-to-core/inc/overview.md aspnetcore/migration/fx-to-core/inc/overview
aspnetcore/migration/fx-to-core/inc/remote-app-setup.md aspnetcore/migration/fx-to-core/inc/remote-app-setup
aspnetcore/migration/fx-to-core/inc/remote-authentication.md aspnetcore/migration/fx-to-core/inc/remote-authentication
aspnetcore/migration/fx-to-core/inc/remote-session.md aspnetcore/migration/fx-to-core/inc/remote-session
aspnetcore/migration/fx-to-core/inc/session.md aspnetcore/migration/fx-to-core/inc/session
aspnetcore/migration/fx-to-core/inc/start.md aspnetcore/migration/fx-to-core/inc/start
aspnetcore/migration/fx-to-core/inc/systemweb-adapters.md aspnetcore/migration/fx-to-core/inc/systemweb-adapters
aspnetcore/migration/fx-to-core/inc/unit-testing.md aspnetcore/migration/fx-to-core/inc/unit-testing
aspnetcore/migration/fx-to-core/inc/usage_guidance.md aspnetcore/migration/fx-to-core/inc/usage_guidance
aspnetcore/migration/fx-to-core/inc/wrapped.md aspnetcore/migration/fx-to-core/inc/wrapped
aspnetcore/migration/fx-to-core/index.md aspnetcore/migration/fx-to-core/index
aspnetcore/migration/fx-to-core/tooling.md aspnetcore/migration/fx-to-core/tooling
aspnetcore/security/cookie-sharing.md aspnetcore/security/cookie-sharing
aspnetcore/toc.yml aspnetcore/toc
aspnetcore/zone-pivot-groups.yml aspnetcore/zone-pivot-groups

@guardrex
Copy link
Collaborator Author

guardrex commented Jul 17, 2025

@wadepickett ... Ok, let's hold here a sec and call THE @BillWagner in for a Q&A.

Hi @BillWagner! 👋 Hope ur well! Question if you have a minute: We had a PR (#35755) go in unsquashed with a set of API cross-reference errors (possibly due to coming from a very old fork of our repo).

It looks like I can just merge this reversion (I plan to execute a regular, non-squashed, merge here). That should fix our 'Merge to Live' PR (#35764) and get it back into good graces with the 🙏 server gods 🙏😄.

However, that's not going to restore the original branch that was being worked on. We'd like to be able to work on that branch to see if we can clear the build errors on a new PR from it (perhaps update the fork and rebase?) ... and then next time squash that PR to merge it to main.

I just researched restoring a deleted branch and ...

  • I don't see a "Restore Branch" button on that PR.
  • I don't see the branch (aspnet-migration-details) in Activity filtered to deleted branches.
  • I'm not aware that a local copy exists of the branch.
  • Not sure about using git reflog. I've never used that approach before.

@twsouthwick
Copy link
Member

If this works, I can create a new pr with a single commit of all the changes we did rebased on the updated main. Let me know if you need me to do anything (I still have the branch local)

@guardrex
Copy link
Collaborator Author

guardrex commented Jul 18, 2025

I still have the branch local

🎉

Awesome!

Yes, I'll proceed now with this to see if we can get the merge-to-live PR back in good standing.

@guardrex guardrex merged commit 08c34aa into main Jul 18, 2025
3 checks passed
@guardrex guardrex deleted the revert-35755-aspnet-migration-details branch July 18, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants