[Bug Fix] High Performance Plan Fix

[MattFromRVA]

Fixes #2319

[Alluseri]

Been 1.5 years since this PR was proposed. And yet...

[timcassell]

I don't think the change is robust enough. If a user explicitly configures high performance power plan, this will ignore it. It should only be ignored if it's not configured.

[MattFromRVA]

Sounds good @timcassell. I will take a look at this when I have some free time.

[MattFromRVA]

@timcassell Ok I have pushed my changes.

My understanding of the original intent in #2319 was to never downgrade to High Performance if the current plan is Ultimate. However, your recent comment makes sense that the code should always use the explicit power plan.

So, I’ve updated the code to only remain on Ultimate if the High Performance plan is not configured—otherwise, the requested plan will be set as expected.

Please let me know if this matches what you’re looking for.

[timcassell]

I can't tell what you're testing here, but it doesn't look like it's testing what a user would actually do. Users set the powerplan via Job.WithPowerPlan(...).

The benchmark runner retrieves the value and applies it here:

BenchmarkDotNet/src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs

Lines 235 to 236 in daa2339

	powerManagementApplier.ApplyPerformancePlan(benchmark.Job.Environment.PowerPlanMode
	?? benchmark.Job.ResolveValue(EnvironmentMode.PowerPlanModeCharacteristic, EnvironmentResolver.Instance).GetValueOrDefault());

To check if the user explicitly set the value, you can do job.HasValue(EnvironmentMode.PowerPlanModeCharacteristic).

[MattFromRVA]

@timcassell Thanks for the additional insight. Looks like I cannot properly test this change as I just realized I cannot change my laptop's settings to Ultimate. I pushed my latest commit if someone else wants to test/make changes.

[timcassell]

This doesn't work, you're skipping the entire benchmark here. You should rather invert the branches, or move it to another function.