Skip to content

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Apr 11, 2021

More words will be here in due course.

@Perksey Perksey marked this pull request as draft April 11, 2021 20:32
@Perksey
Copy link
Member Author

Perksey commented Jul 2, 2021

I think the next steps for this is fixing up the overloads so that they're less specific/hardcoded, and then cleaning up the code a bit (i.e. removing commented out stuff). I'm happy to ship with the functionality we have now given those two points.

@Perksey Perksey marked this pull request as ready for review February 5, 2022 20:53
@Perksey Perksey requested a review from a team as a code owner February 5, 2022 20:53
@Perksey
Copy link
Member Author

Perksey commented Feb 5, 2022

The longest-standing PR currently open today is now ready for review.

@Perksey
Copy link
Member Author

Perksey commented Feb 5, 2022

In case the reader is not aware: we have decided not to include codefixes at this time due to time constraints on the maintenance team. We definitely want this however and will accept community contributions for adding them. Only the F1 functionality is included today.

@HurricanKai
Copy link
Member

(Code fixes are expected for 3.0)

@Perksey
Copy link
Member Author

Perksey commented Apr 19, 2022

Will try and revisit this for 2.16, sorry this is taking so long.

@Perksey Perksey self-assigned this Apr 19, 2022
@Perksey Perksey added this to the 2.X milestone Apr 19, 2022
@Perksey
Copy link
Member Author

Perksey commented May 13, 2022

I'm closing this as I won't be coming back to this, and with all maintainers being dedicated to 3.0 I'm not sure if anyone else would either. I've protected the branch, so it should stay put should anyone else want to pick this up.

@Perksey Perksey closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants