Skip to content

Disable packet multiplexing design by default #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Aug 2, 2025

Description

Enables below App Context switches by default until packet multiplexing is ready for production use.

Switch.Microsoft.Data.SqlClient.UseCompatibilityProcessSni
Switch.Microsoft.Data.SqlClient.UseCompatibilityAsyncBehaviour

Disabling feature on main branch until a decision is made to fix the feature design and implementation.

@Copilot Copilot AI review requested due to automatic review settings August 2, 2025 07:18
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner August 2, 2025 07:18
@cheenamalhotra cheenamalhotra added this to the 6.1.1 milestone Aug 2, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the packet multiplexing design by default by enabling two AppContext switches that maintain compatibility with the previous behavior. The change addresses issues with the new packet multiplexing functionality that is not yet ready for production use.

  • Enables UseCompatibilityProcessSni and UseCompatibilityAsyncBehaviour switches by default
  • Updates logic to default to true when switches are not explicitly set by users
  • Updates tests and comments to reflect the new default behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
LocalAppContextSwitches.cs Changes default values for compatibility switches from false to true when not explicitly set
LocalAppContextSwitchesTest.cs Updates unit tests to expect true as default values for the compatibility switches
MultiplexerTests.cs Updates test helper method to return true as default when switch is not set

@ErikEJ
Copy link
Contributor

ErikEJ commented Aug 2, 2025

LGTM

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@paulmedynski
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra
Copy link
Member Author

Overtaken by #3556

@cheenamalhotra cheenamalhotra removed this from the 6.1.1 milestone Aug 14, 2025
@cheenamalhotra cheenamalhotra deleted the dev/cheena/use-compat-by-default branch August 15, 2025 19:49
@cheenamalhotra cheenamalhotra restored the dev/cheena/use-compat-by-default branch August 15, 2025 22:16
@cheenamalhotra
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra cheenamalhotra added this to the 7.0-preview1 milestone Aug 15, 2025
Copy link

codecov bot commented Aug 16, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.34%. Comparing base (1e1c52a) to head (5b75d81).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...icrosoft/Data/SqlClient/LocalAppContextSwitches.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3537      +/-   ##
==========================================
- Coverage   69.14%   67.34%   -1.80%     
==========================================
  Files         276      274       -2     
  Lines       62414    62478      +64     
==========================================
- Hits        43154    42075    -1079     
- Misses      19260    20403    +1143     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore 72.35% <50.00%> (-0.61%) ⬇️
netfx 66.17% <50.00%> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants