[6.0] Add CodeQL suppression for DefaultAzureCredential and fix macOS CI failures #3551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3542) * Task 37261: [S360] [SM05137] DefaultAzureCredential use in Production - Adjusted CodeQL suppression to meet the strict requirements of where it may appear relative to the flagged code. * Task 37261: [S360] [SM05137] DefaultAzureCredential use in Production - Adding catch for macOS socket error to log and ignore.
There was a problem hiding this comment.
Pull Request Overview
This PR ports changes from the main branch to version 6.0, focusing on fixing CodeQL security warnings and macOS CI failures. The changes improve code quality and cross-platform compatibility by addressing static analysis tool requirements and platform-specific socket handling issues.
- Adds proper CodeQL suppression comments for DefaultAzureCredential instantiation with detailed justification
- Implements error handling for macOS socket timeout setting failures with appropriate logging
- Refactors code to meet strict CodeQL suppression placement requirements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ActiveDirectoryAuthenticationProvider.cs | Adds CodeQL suppression with detailed justification and refactors DefaultAzureCredential instantiation |
| SNITcpHandle.cs | Adds error handling for socket timeout reset failures on macOS with logging |
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
Show resolved
Hide resolved
mdaigle
approved these changes
Aug 8, 2025
cheenamalhotra
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #3542.