Refactor TorchVision Normalize method like pytorch. #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedZero
changed the title
…rongLengths` test for ArgumentException in Normalize function
Renamed the method `GetImageNumChannels` to `get_image_num_channels` in `Functional.cs`. Added a summary documentation comment to the `get_image_num_channels` method, detailing its purpose, parameter, and return value. Updated the call to this method in `Normalize.cs` to reflect the new name.
|
This is exactly what I need, currently TorchSharp in image loading and transformer tensor need to manually adjust the shape to adapt to dimensional changes. |
|
@dotnet-policy-service agree |
|
@alinpahontu2912 Could you please take a look at this PR when you have time? Your feedback would be appreciated. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor TorchVision Normalize method like pytorch to support any kind of Tensor Image (.., C, H, W)