[release/9.4] Backporting a few get-aspire-cli script PRs #10586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0567c27)
## Key Changes ### 1. **Quality Level Behavior** - **`dev`**: Downloads latest development builds from the `main` branch - **`staging`**: Downloads release candidate builds (rc/daily) - **`ga`**: Downloads generally available release builds (ga/daily) - **Default**: `staging` quality is used when no quality is specified ### 2. **Updated URL Mappings for Quality Levels** - **PowerShell Script (`get-aspire-cli.ps1`)**: - `dev` quality now maps to: `https://aka.ms/dotnet/9/aspire/daily` - `staging` quality now maps to: `https://aka.ms/dotnet/9/aspire/rc/daily` - `ga` quality now maps to: `https://aka.ms/dotnet/9/aspire/ga/daily` - **Bash Script (`get-aspire-cli.sh`)**: - Updated with corresponding URL mappings to match PowerShell script - Consistent quality-to-URL mapping across both script implementations ### 3. **Support for -WhatIf and --dry-run** - This will be useful for testing ### 4. **Code Quality Improvements** The code has been made more idiomatic in many ways: - Better PowerShell coding practices and conventions - Improved error handling patterns - Enhanced cross-platform compatibility - More robust parameter validation - Cleaner function organization and separation of concerns Co-authored-by: Copilot <[email protected]> (cherry picked from commit a5d2813)
* [cli scripts] Fix ps1 -Help which failed because it called WriteMessage before it was defined in the file * Update the URLs to use aka.ms links * cleanup - set the default quality in one place * Update docs/using-latest-daily.md Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> (cherry picked from commit f8c4759)
There was a problem hiding this comment.
Pull Request Overview
This PR backports several improvements to the Aspire CLI download scripts, updating them to use new Quality mappings and fixing various issues. The main changes include updating the URL construction logic to use quality-based aka.ms URLs instead of version-based ones, adding new dry-run functionality, improving error handling, and updating documentation to reflect the new quality options.
- Updates URL construction to use new Quality mappings (dev, staging, release) with aka.ms URLs
- Adds dry-run functionality and enhanced error handling to both shell and PowerShell scripts
- Updates documentation to reflect the new quality options and installation instructions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/scripts/get-aspire-cli.sh | Major refactoring with new URL construction, dry-run support, and improved argument validation |
| eng/scripts/get-aspire-cli.ps1 | Complete rewrite with enhanced error handling, new quality mappings, and SupportsShouldProcess |
| eng/scripts/README.md | Updates quality documentation from 'daily' to new quality values (dev, staging, ga) |
| docs/using-latest-daily.md | Changes installation instructions from dotnet tool to script-based installation |
|
This brings the scripts at par with |
davidfowl
approved these changes
Jul 22, 2025
mitchdenny
approved these changes
Jul 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the following overlapping PRs:
using-latest-daily.md: Update instructions to get cli (#10506)
Update scripts to use the new Quality mappings to urls (#10479)
using-latest-daily.md: fix instructions for getting daily cli (#10544)
get-aspire-cli: Some fixes and cleanup (#10578)