Skip to content

[SignalR] [Java] Fix NPE when closing hub connection during negotiation #62319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
+28 −1
Merged

[SignalR] [Java] Fix NPE when closing hub connection during negotiation #62319

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1993182
[SignalR] [Java] Fix NPE when closing hub connection during negotiation
Sejsel Jun 11, 2025
dd127b1
Remove unnecessary test delay
Sejsel Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/HubConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,8 @@ private Completable stop(String errorMessage) {
CompletableSubject subject = CompletableSubject.create();
startTask.onErrorComplete().subscribe(() ->
{
Completable stop = connectionState.transport.stop();
Transport transport = connectionState.transport;
Completable stop = (transport != null) ? transport.stop() : Completable.complete();
stop.subscribe(() -> subject.onComplete(), e -> subject.onError(e));
});

Expand Down
20 changes: 20 additions & 0 deletions ...nalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/HubConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2783,6 +2783,26 @@ public void negotiateSentOnStart() {
assertEquals("http://example.com/negotiate?negotiateVersion=1", sentRequests.get(0).getUrl());
}

@Test
public void closeWithPendingNegotiate() {
TestHttpClient client = new TestHttpClient()
.on("POST", (req) -> Single.just(new HttpResponse(404, "", TestUtils.emptyByteBuffer)).delay(200, TimeUnit.MILLISECONDS));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to set the Single's value after calling hubConnection.stop so we don't rely on delays as much?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, that is a good call. Made the change, and also checked that the bug would have been caught with the changed test.


HubConnection hubConnection = HubConnectionBuilder
.create("http://example.com")
.withHttpClient(client)
.build();

Completable start = hubConnection.start();
assertEquals(HubConnectionState.CONNECTING, hubConnection.getConnectionState());
hubConnection.stop().timeout(3, TimeUnit.SECONDS).blockingAwait();
assertEquals(HubConnectionState.DISCONNECTED, hubConnection.getConnectionState());

HttpRequestException exception = assertThrows(HttpRequestException.class, () -> start.blockingAwait(10, TimeUnit.SECONDS));
assertEquals("Unexpected status code returned from negotiate: 404 .", exception.getMessage());
assertEquals(404, exception.getStatusCode());
}

@Test
public void negotiateThatRedirectsForeverFailsAfter100Tries() {
TestHttpClient client = new TestHttpClient().on("POST", "http://example.com/negotiate?negotiateVersion=1",
Expand Down
Loading