Skip to content

Wrap OnNavigateTo callback with GetErrorHandledTask for proper exception logging #62414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 22, 2025
Merged

Wrap OnNavigateTo callback with GetErrorHandledTask for proper exception logging #62414

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
129d5aa
Initial plan for issue
Copilot Jun 19, 2025
5129adc
Wrap OnNavigateTo callback with GetErrorHandledTask for proper except…
Copilot Jun 19, 2025
949150a
Add test for OnNavigateTo callback exception handling in NavigationMa…
Copilot Jun 19, 2025
80512e6
Use correct Initialize method signature for OnNavigateTo callback
Copilot Jun 19, 2025
ae9db69
Finish the test.
ilonatommy Jul 2, 2025
3983ad0
Fix nullability.
ilonatommy Jul 2, 2025
2ebe7c8
Make deterministic.
ilonatommy Jul 2, 2025
3702281
Even more deterministic.
ilonatommy Jul 3, 2025
69c6204
Revert all changes to NavigationManagerTest.cs as requested
Copilot Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ internal async Task InitializeStandardComponentServicesAsync(
IFormCollection? form = null)
{
var navigationManager = httpContext.RequestServices.GetRequiredService<NavigationManager>();
((IHostEnvironmentNavigationManager)navigationManager)?.Initialize(GetContextBaseUri(httpContext.Request), GetFullUri(httpContext.Request), OnNavigateTo);
((IHostEnvironmentNavigationManager)navigationManager)?.Initialize(GetContextBaseUri(httpContext.Request), GetFullUri(httpContext.Request), uri =>
{
_ = GetErrorHandledTask(OnNavigateTo(uri));
return Task.CompletedTask;
});

navigationManager?.OnNotFound += (sender, args) =>
{
Expand Down
Loading