Obsolete RazorRuntimeCompilation

src/Mvc/Mvc.Razor.RuntimeCompilation/src/AssemblyPartExtensions.cs

@@ -9,6 +9,7 @@ namespace Microsoft.AspNetCore.Mvc.ApplicationParts;
 /// <summary>
 /// Static class that adds methods to <see cref="AssemblyPart"/>.
 /// </summary>
+[Obsolete("Razor runtime compilation is obsolete and is not recommended for production scenarios. For production scenarios, use the default build time compilation. For development scenarios, use Hot Reload instead. For more information, visit https://aka.ms/aspnet/deprecate/003.", DiagnosticId = "ASPDEPR003")]
 public static class AssemblyPartExtensions
 {
     /// <inheritdoc />

src/Mvc/Mvc.Razor.RuntimeCompilation/src/DependencyInjection/MvcRazorRuntimeCompilationOptionsSetup.cs

@@ -6,7 +6,9 @@
 
 namespace Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
 internal sealed class MvcRazorRuntimeCompilationOptionsSetup : IConfigureOptions<MvcRazorRuntimeCompilationOptions>
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
 {
     private readonly IWebHostEnvironment _hostingEnvironment;
 
@@ -15,7 +17,9 @@ public MvcRazorRuntimeCompilationOptionsSetup(IWebHostEnvironment hostingEnviron
         _hostingEnvironment = hostingEnvironment ?? throw new ArgumentNullException(nameof(hostingEnvironment));
     }
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
     public void Configure(MvcRazorRuntimeCompilationOptions options)
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     {
         ArgumentNullException.ThrowIfNull(options);
 

src/Mvc/Mvc.Razor.RuntimeCompilation/src/DependencyInjection/RazorRuntimeCompilationMvcBuilderExtensions.cs

@@ -8,6 +8,7 @@ namespace Microsoft.Extensions.DependencyInjection;
 /// <summary>
 /// Static class that adds razor compilation extension methods.
 /// </summary>
+[Obsolete("Razor runtime compilation is obsolete and is not recommended for production scenarios. For production scenarios, use the default build time compilation. For development scenarios, use Hot Reload instead. For more information, visit https://aka.ms/aspnet/deprecate/003.", DiagnosticId = "ASPDEPR003")]
 public static class RazorRuntimeCompilationMvcBuilderExtensions
 {
     /// <summary>

src/Mvc/Mvc.Razor.RuntimeCompilation/src/DependencyInjection/RazorRuntimeCompilationMvcCoreBuilderExtensions.cs

@@ -20,6 +20,7 @@ namespace Microsoft.Extensions.DependencyInjection;
 /// <summary>
 /// Static class that adds razor runtime compilation extension methods.
 /// </summary>
+[Obsolete("Razor runtime compilation is obsolete and is not recommended for production scenarios. For production scenarios, use the default build time compilation. For development scenarios, use Hot Reload instead. For more information, visit https://aka.ms/aspnet/deprecate/003.", DiagnosticId = "ASPDEPR003")]
 public static class RazorRuntimeCompilationMvcCoreBuilderExtensions
 {
     /// <summary>

src/Mvc/Mvc.Razor.RuntimeCompilation/src/FileProviderRazorProjectFileSystem.cs

@@ -34,7 +34,9 @@ public override RazorProjectItem GetItem(string path, string? fileKind)
         path = NormalizeAndEnsureValidPath(path);
         var fileInfo = FileProvider.GetFileInfo(path);
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         return new FileProviderRazorProjectItem(fileInfo, basePath: string.Empty, filePath: path, root: _hostingEnvironment.ContentRootPath, fileKind);
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     }
 
     public override IEnumerable<RazorProjectItem> EnumerateItems(string path)
@@ -63,7 +65,9 @@ private IEnumerable<RazorProjectItem> EnumerateFiles(IDirectoryContents director
                 {
                     var filePath = prefix + "/" + fileInfo.Name;
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
                     yield return new FileProviderRazorProjectItem(fileInfo, basePath, filePath: filePath, root: _hostingEnvironment.ContentRootPath);
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
                 }
             }
         }

src/Mvc/Mvc.Razor.RuntimeCompilation/src/FileProviderRazorProjectItem.cs

@@ -9,6 +9,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
 /// <summary>
 /// A file provider <see cref="RazorProjectItem"/>.
 /// </summary>
+[Obsolete("Razor runtime compilation is obsolete and is not recommended for production scenarios. For production scenarios, use the default build time compilation. For development scenarios, use Hot Reload instead. For more information, visit https://aka.ms/aspnet/deprecate/003.", DiagnosticId = "ASPDEPR003")]
 public class FileProviderRazorProjectItem : RazorProjectItem
 {
     private readonly string _root;

src/Mvc/Mvc.Razor.RuntimeCompilation/src/MvcRazorRuntimeCompilationOptions.cs

@@ -10,6 +10,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
 /// <summary>
 /// Used to configure razor compilation.
 /// </summary>
+[Obsolete("Razor runtime compilation is obsolete and is not recommended for production scenarios. For production scenarios, use the default build time compilation. For development scenarios, use Hot Reload instead. For more information, visit https://aka.ms/aspnet/deprecate/003.", DiagnosticId = "ASPDEPR003")]
 public class MvcRazorRuntimeCompilationOptions
 {
     /// <summary>

src/Mvc/Mvc.Razor.RuntimeCompilation/src/RazorReferenceManager.cs

@@ -14,14 +14,18 @@ internal class RazorReferenceManager
 #pragma warning restore CA1852 // Seal internal types
 {
     private readonly ApplicationPartManager _partManager;
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
     private readonly MvcRazorRuntimeCompilationOptions _options;
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     private object _compilationReferencesLock = new object();
     private bool _compilationReferencesInitialized;
     private IReadOnlyList<MetadataReference>? _compilationReferences;
 
     public RazorReferenceManager(
         ApplicationPartManager partManager,
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         IOptions<MvcRazorRuntimeCompilationOptions> options)
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     {
         _partManager = partManager;
         _options = options.Value;

src/Mvc/Mvc.Razor.RuntimeCompilation/src/RazorRuntimeCompilationHostingStartup.cs

@@ -11,6 +11,8 @@ internal sealed class RazorRuntimeCompilationHostingStartup : IHostingStartup
     public void Configure(IWebHostBuilder builder)
     {
         // Add Razor services
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         builder.ConfigureServices(RazorRuntimeCompilationMvcCoreBuilderExtensions.AddServices);
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     }
 }

src/Mvc/Mvc.Razor.RuntimeCompilation/src/RuntimeCompilationFileProvider.cs

@@ -8,10 +8,14 @@ namespace Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
 
 internal sealed class RuntimeCompilationFileProvider
 {
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
     private readonly MvcRazorRuntimeCompilationOptions _options;
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     private IFileProvider? _compositeFileProvider;
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
     public RuntimeCompilationFileProvider(IOptions<MvcRazorRuntimeCompilationOptions> options)
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     {
         ArgumentNullException.ThrowIfNull(options);
 
@@ -31,15 +35,19 @@ public IFileProvider FileProvider
         }
     }
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
     private static IFileProvider GetCompositeFileProvider(MvcRazorRuntimeCompilationOptions options)
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     {
         var fileProviders = options.FileProviders;
         if (fileProviders.Count == 0)
         {
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
             var message = Resources.FormatFileProvidersAreRequired(
                 typeof(MvcRazorRuntimeCompilationOptions).FullName,
                 nameof(MvcRazorRuntimeCompilationOptions.FileProviders),
                 typeof(IFileProvider).FullName);
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
             throw new InvalidOperationException(message);
         }
         else if (fileProviders.Count == 1)

src/Mvc/Mvc.Razor.RuntimeCompilation/test/DependencyInjection/RazorRuntimeCompilationMvcCoreBuilderExtensionsTest.cs

@@ -19,7 +19,9 @@ public void AddServices_ReplacesRazorViewCompiler()
             .AddSingleton<IViewCompilerProvider, DefaultViewCompilerProvider>();
 
         // Act
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         RazorRuntimeCompilationMvcCoreBuilderExtensions.AddServices(services);
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
 
         // Assert
         var serviceDescriptor = Assert.Single(services, service => service.ServiceType == typeof(IViewCompilerProvider));
@@ -34,7 +36,9 @@ public void AddServices_ReplacesActionDescriptorProvider()
             .AddSingleton<IActionDescriptorProvider, CompiledPageActionDescriptorProvider>();
 
         // Act
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         RazorRuntimeCompilationMvcCoreBuilderExtensions.AddServices(services);
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
 
         // Assert
         var serviceDescriptor = Assert.Single(services, service => service.ServiceType == typeof(IActionDescriptorProvider));

src/Mvc/Mvc.Razor.RuntimeCompilation/test/FileProviderRazorProjectFileSystemTest.cs

@@ -243,10 +243,12 @@ private static FileProviderRazorProjectFileSystem GetRazorProjectFileSystem(
         TestFileProvider fileProvider,
         string contentRootPath = "BasePath")
     {
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         var options = Options.Create(new MvcRazorRuntimeCompilationOptions
         {
             FileProviders = { fileProvider }
         });
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
         var compilationFileProvider = new RuntimeCompilationFileProvider(options);
         var fileSystem = new FileProviderRazorProjectFileSystem(
             compilationFileProvider,

src/Mvc/Mvc.Razor.RuntimeCompilation/test/RazorReferenceManagerTest.cs

@@ -15,7 +15,9 @@ public class RazorReferenceManagerTest
     public void GetCompilationReferences_CombinesApplicationPartAndOptionMetadataReferences()
     {
         // Arrange
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         var options = new MvcRazorRuntimeCompilationOptions();
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
         var additionalReferencePath = "additional-path";
         options.AdditionalReferencePaths.Add(additionalReferencePath);
 

src/Mvc/Mvc.Razor.RuntimeCompilation/test/RuntimeCompilationFileProviderTest.cs

@@ -12,11 +12,13 @@ public class RuntimeCompilationFileProviderTest
     public void GetFileProvider_ThrowsIfNoConfiguredFileProviders()
     {
         // Arrange
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         var expected =
             $"'{typeof(MvcRazorRuntimeCompilationOptions).FullName}.{nameof(MvcRazorRuntimeCompilationOptions.FileProviders)}' must " +
             $"not be empty. At least one '{typeof(IFileProvider).FullName}' is required to locate a view for " +
             "rendering.";
         var options = Options.Create(new MvcRazorRuntimeCompilationOptions());
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
 
         var fileProvider = new RuntimeCompilationFileProvider(options);
 

src/Mvc/Mvc.Razor.RuntimeCompilation/test/RuntimeViewCompilerTest.cs

@@ -824,10 +824,12 @@ private static TestRazorViewCompiler GetViewCompiler(
         CSharpCompiler csharpCompiler = null)
     {
         fileProvider = fileProvider ?? new TestFileProvider();
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         var options = Options.Create(new MvcRazorRuntimeCompilationOptions
         {
             FileProviders = { fileProvider }
         });
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
         var compilationFileProvider = new RuntimeCompilationFileProvider(options);
 
         referenceManager = referenceManager ?? CreateReferenceManager();
@@ -855,7 +857,9 @@ private static RazorReferenceManager CreateReferenceManager()
         var assembly = typeof(RuntimeViewCompilerTest).Assembly;
         applicationPartManager.ApplicationParts.Add(new AssemblyPart(assembly));
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         return new RazorReferenceManager(applicationPartManager, Options.Create(new MvcRazorRuntimeCompilationOptions()));
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     }
 
     private class TestRazorViewCompiler : RuntimeViewCompiler

src/Mvc/Mvc.Razor.RuntimeCompilation/test/TestInfrastructure/TestRazorReferenceManager.cs

@@ -12,7 +12,9 @@ internal class TestRazorReferenceManager : RazorReferenceManager
     public TestRazorReferenceManager()
         : base(
             new ApplicationPartManager(),
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
             Options.Create(new MvcRazorRuntimeCompilationOptions()))
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     {
         CompilationReferences = Array.Empty<MetadataReference>();
     }

src/Mvc/test/Mvc.FunctionalTests/ErrorPageTests.cs

@@ -50,7 +50,9 @@ public async Task CompilationFailuresAreListedByErrorPageMiddleware()
     {
         // Arrange
         var factory = Factory.WithWebHostBuilder(b => b.UseStartup<ErrorPageMiddlewareWebSite.Startup>());
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         factory = factory.WithWebHostBuilder(b => b.ConfigureTestServices(serviceCollection => serviceCollection.Configure<MvcRazorRuntimeCompilationOptions>(ConfigureRuntimeCompilationOptions)));
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
 
         var client = factory.CreateDefaultClient();
         client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("text/html"));
@@ -70,6 +72,7 @@ public async Task CompilationFailuresAreListedByErrorPageMiddleware()
         Assert.Contains(expected, content);
         Assert.DoesNotContain(PreserveCompilationContextMessage, content);
 
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         static void ConfigureRuntimeCompilationOptions(MvcRazorRuntimeCompilationOptions options)
         {
             options.AdditionalReferencePaths.Add(typeof(string).Assembly.Location);
@@ -81,6 +84,7 @@ static void ConfigureRuntimeCompilationOptions(MvcRazorRuntimeCompilationOptions
                 options.AdditionalReferencePaths.Add(path);
             }
         }
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
     }
 
     [Fact]

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

@@ -24,6 +24,7 @@ public class RazorBuildTest : LoggedTest
     protected override void Initialize(TestContext context, MethodInfo methodInfo, object[] testMethodArguments, ITestOutputHelper testOutputHelper)
     {
         base.Initialize(context, methodInfo, testMethodArguments, testOutputHelper);
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         Factory = new MvcTestFixture<RazorBuildWebSite.Startup>(LoggerFactory)
             .WithWebHostBuilder(b => b.ConfigureTestServices(serviceCollection => serviceCollection.Configure<MvcRazorRuntimeCompilationOptions>(ConfigureRuntimeCompilationOptions)));
 
@@ -36,6 +37,7 @@ static void ConfigureRuntimeCompilationOptions(MvcRazorRuntimeCompilationOptions
                 options.AdditionalReferencePaths.Add(path);
             }
         }
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
         Client = Factory.CreateDefaultClient();
     }
 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

@@ -21,6 +21,7 @@ public class RazorRuntimeCompilationHostingStartupTest : LoggedTest
     protected override void Initialize(TestContext context, MethodInfo methodInfo, object[] testMethodArguments, ITestOutputHelper testOutputHelper)
     {
         base.Initialize(context, methodInfo, testMethodArguments, testOutputHelper);
+#pragma warning disable ASPDEPR003 // Type or member is obsolete
         Factory = new MvcTestFixture<RazorBuildWebSite.StartupWithHostingStartup>(LoggerFactory)
             .WithWebHostBuilder(b => b.UseStartup<RazorBuildWebSite.StartupWithHostingStartup>())
             .WithWebHostBuilder(b => b.ConfigureTestServices(serviceCollection => serviceCollection.Configure<MvcRazorRuntimeCompilationOptions>(ConfigureRuntimeCompilationOptions)));
@@ -34,6 +35,7 @@ static void ConfigureRuntimeCompilationOptions(MvcRazorRuntimeCompilationOptions
                 options.AdditionalReferencePaths.Add(path);
             }
         }
+#pragma warning restore ASPDEPR003 // Type or member is obsolete
         Client = Factory.CreateDefaultClient();
     }