Skip to content

Implemented fix to match HubConnection.cs logic (https://github.com/d… #62812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Implemented fix to match HubConnection.cs logic (https://github.com/d… #62812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/SignalR/clients/ts/signalr/src/HubConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ export class HubConnection {
let previousReconnectAttempts = 0;
let retryError = error !== undefined ? error : new Error("Attempting to reconnect due to a unknown error.");

let nextRetryDelay = this._getNextRetryDelay(previousReconnectAttempts++, 0, retryError);
let nextRetryDelay = this._getNextRetryDelay(previousReconnectAttempts, 0, retryError);

if (nextRetryDelay === null) {
this._logger.log(LogLevel.Debug, "Connection not reconnecting because the IRetryPolicy returned null on the first reconnect attempt.");
Expand Down Expand Up @@ -902,7 +902,7 @@ export class HubConnection {
}

while (nextRetryDelay !== null) {
this._logger.log(LogLevel.Information, `Reconnect attempt number ${previousReconnectAttempts} will start in ${nextRetryDelay} ms.`);
this._logger.log(LogLevel.Information, `Reconnect attempt number ${previousReconnectAttempts + 1} will start in ${nextRetryDelay} ms.`);

await new Promise((resolve) => {
this._reconnectDelayHandle = setTimeout(resolve, nextRetryDelay!);
Expand Down Expand Up @@ -941,8 +941,9 @@ export class HubConnection {
return;
}

previousReconnectAttempts++;
retryError = e instanceof Error ? e : new Error((e as any).toString());
nextRetryDelay = this._getNextRetryDelay(previousReconnectAttempts++, Date.now() - reconnectStartTime, retryError);
nextRetryDelay = this._getNextRetryDelay(previousReconnectAttempts, Date.now() - reconnectStartTime, retryError);
}
}

Expand Down
Loading