Skip to content

Follow-up on IsLocalhost TLD local dev #62838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

Follow-up on IsLocalhost TLD local dev #62838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
126ebcc
Refactor IsLocalhost to static method
Jul 21, 2025
b21abed
Review comment
Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Servers/Kestrel/Core/src/Internal/AddressBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,21 +142,21 @@ internal static ListenOptions ParseAddress(string address, out bool https)

return options;

bool IsLocalhost(string host, out string? prefix)
static bool IsLocalhost(string host, out string? prefix)
{
// Check for "localhost"
if (string.Equals(parsedAddress.Host, "localhost", StringComparison.OrdinalIgnoreCase))
if (string.Equals(host, "localhost", StringComparison.OrdinalIgnoreCase))
{
prefix = null;
return true;
}

// Check for use of .localhost TLD (Top Level Domain)
if (host.EndsWith(".localhost", StringComparison.OrdinalIgnoreCase)
&& !string.Equals(parsedAddress.Host, ".localhost", StringComparison.OrdinalIgnoreCase))
const string localhostTld = ".localhost";
if (host.Length > localhostTld.Length && host.EndsWith(localhostTld, StringComparison.OrdinalIgnoreCase))
{
// Take all but the .localhost TLD as the prefix
prefix = host[..^10]; // 10 is the length of ".localhost"
prefix = host[..^localhostTld.Length];
return true;
}

Expand Down
Loading