Skip to content

Stop using outdated 5.0 sdk image in wasm benchmarks #62884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Stop using outdated 5.0 sdk image in wasm benchmarks #62884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/benchmarkapps/Wasm.Performance/dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/dotnet/sdk:5.0 AS build
FROM mcr.microsoft.com/dotnet/sdk:latest AS build

Copy link
Preview

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'latest' tag in Docker images can lead to unpredictable builds and compatibility issues. Consider pinning to a specific version like 'mcr.microsoft.com/dotnet/sdk:9.0' to ensure reproducible builds.

Suggested change
FROM mcr.microsoft.com/dotnet/sdk:latest AS build
FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build

Copilot uses AI. Check for mistakes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're fine with that risk since we don't use the dotnet from the system anyway. Otherwise we'll just forget to bump this again in 2+ years.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only concern with latest is not seeing the image change in the diff when it happens but I'm fine with taking this and discussing options

Copy link
Member Author

@akoeplinger akoeplinger Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it should be pretty obvious since it'd happen right around 10.0 GA.
apart from that the OS version is also not set in stone for the tags either, we'd need to use a specific 9.0-bookworm tag

ENV StressRunDuration=0
ARG DEBIAN_FRONTEND=noninteractive
Expand Down
Loading