-
Notifications
You must be signed in to change notification settings - Fork 10.4k
fix SignalR http2 SkipNegotiation error #62940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…sion is not http2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where SignalR clients using HTTP/2 with SkipNegotiation
mode were not properly creating an HttpClient
, which caused errors. The fix ensures that HttpClient
is always created regardless of the negotiation and transport settings.
- Removes conditional logic that prevented
HttpClient
creation in certain scenarios - Ensures
HttpClient
is available for all transport configurations
Comments suppressed due to low confidence (1)
src/SignalR/clients/csharp/Http.Connections.Client/src/HttpConnection.cs:151
- The removal of the conditional logic that prevented HttpClient creation in SkipNegotiation + WebSockets-only scenarios should be covered by tests to ensure this fix works correctly and prevent regression.
_httpClient = CreateHttpClient();
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
fix SignalR http2 SkipNegotiation error
Description
Creating
HttpClient
for WebSocketSkipNegotiation
mode alsoFixes #59303