Skip to content

Revert "Skip RequestPathBase_WithDoubleSlashes_Split for now" #62996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 29, 2025

The rollout may already be done

@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 21:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that temporarily skipped two test methods during CI execution. The purpose is to re-enable the RequestPathBase_Split and RequestPathBase_WithDoubleSlashes_Split test methods, likely because the rollout mentioned in the description has been completed.

  • Removes [SkipOnCI] attributes from two test methods
  • Re-enables previously disabled functional tests for request path base handling

@github-actions github-actions bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jul 29, 2025
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it passes of course

@JamesNK
Copy link
Member

JamesNK commented Jul 30, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 30, 2025

Build failure is unrelated & being addressed in #62585. Going to force-merge this

@wtgodbe wtgodbe merged commit 29f49f3 into main Jul 30, 2025
28 of 31 checks passed
@wtgodbe wtgodbe deleted the revert-62931-wtgodbe/skippin branch July 30, 2025 04:09
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc1 milestone Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants