Improve logging and error handling for IIS ASP.NET Core module shadow copy #63000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logging and error handling for IIS ASP.NET Core module shadow copy
Summary of the changes (Less than 80 chars)
Improve shadow copy logging and error handling
Description
Goal of this PR: if shadow copy fails due to lack of permissions to the shadow copy directory
Laundry list of changes
Fixes #62148
Bare in mind I am well aware this is not production ready. However, I am not a C++ enjoyer (yet), so I am opening this PR with a reasonable working solution to get it reviewed instead of trying to perfect it myself.
I have left some TODOs in here which are mostly questions for the people who are going to review it. Once they are addressed I will remove them.
The code displays a new 500 error about shadow copying: what's the protocol on sub error codes for these? Is reusing existing ones okay or should a new one be made? I presume existing documentation elsewhere would also need to be updated?