Added usage of TimeProvider instead of DateTimeOffset

[StickFun]

Added usage of TimeProvider instead of DateTimeOffset

Description

Added usage of TimeProvider for NET 8 and higher versions.
Other versions using DateTimeOffset

Fixes #62796

[StickFun]

@dotnet-policy-service agree

[martincostello]

If you made the #if just change the behaviour of UtcNow() you could do it in just one place and then use the method everywhere.

[StickFun]

Using #if inside UtcNow() causes CA1822 error and results in build failure. This happens because the ServiceProvider field is used only in .NET 8 and higher versions. For older versions, this method should be marked static.

    private DateTimeOffset UtcNow()
    {
#if NET8_0_OR_GREATER
        var timeProvider = ServiceProvider.GetService<TimeProvider>();
        return timeProvider?.GetUtcNow() ?? DateTimeOffset.UtcNow;
#else
        return DateTimeOffset.UtcNow;
#endif
    }

Another solution I see is to create two separate methods for UtcNow(). One of them should be static for older versions and the other should not.

#if NET8_0_OR_GREATER
    private DateTimeOffset UtcNow()
    {
        var timeProvider = ServiceProvider.GetService<TimeProvider>();
        return timeProvider?.GetUtcNow() ?? DateTimeOffset.UtcNow;
    }
#else
    private static DateTimeOffset UtcNow()
    {
        return DateTimeOffset.UtcNow;
    }
#endif

If you have any other ideas or approaches for this, please let me know.

[martincostello]

If it were me I would do the second one.

[StickFun]

Changed UtcNow method implementation

[martincostello]

Maybe add a test that demonstrates it's used for .NET 8.0+, but otherwise looks ok to me.

[StickFun]

Maybe add a test that demonstrates it's used for .NET 8.0+, but otherwise looks ok to me.

Added unit test that verifies using TimeProvider

[StickFun]

@martincostello, do I need to rerun CI/CD myself and ping reviewer for last approve?

[martincostello]

If you close and reopen the PR it will run it again.

[StickFun]

@martincostello, is there anything else I should do to merge this PR?

[martincostello]

Assuming the test failures aren't due to your changes, you'll just have to wait for someone from the aspnetcore team to look at it and merge it.