Skip to content

Improve nullable annotation on CancelInvocationMessage.InvocationId #63083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Improve nullable annotation on CancelInvocationMessage.InvocationId #63083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/SignalR/common/SignalR.Common/src/Protocol/CancelInvocationMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,7 @@ public class CancelInvocationMessage : HubInvocationMessage
public CancelInvocationMessage(string invocationId) : base(invocationId)
{
}

/// <inheritdoc cref="HubInvocationMessage.InvocationId" />
public new string InvocationId => base.InvocationId!;
Copy link
Preview

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML documentation comment should be more descriptive than just inheriting from the base class. Since this property provides stronger null safety guarantees than the base property, the documentation should explain this improvement and include proper XML doc tags like <summary> instead of just <inheritdoc cref="..."/>.

Copilot uses AI. Check for mistakes.

}
1 change: 1 addition & 0 deletions src/SignalR/common/SignalR.Common/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#nullable enable
Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!
1 change: 1 addition & 0 deletions src/SignalR/common/SignalR.Common/src/PublicAPI/net462/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#nullable enable
Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!
1 change: 1 addition & 0 deletions src/SignalR/common/SignalR.Common/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#nullable enable
Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!
Loading