-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Include a warning about host spoofing in xml #63174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your PR, @@divyeshio. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds important security-related documentation to the RequireHost
method by including XML documentation remarks that warn developers about host spoofing vulnerabilities. The changes provide guidance on how to properly verify server names and local ports to prevent spoofing attacks.
- Adds comprehensive XML documentation with security warnings about Host header spoofing
- Provides specific mitigation recommendations using TLS handshake verification and connection info validation
- Includes a new using directive for
Microsoft.AspNetCore.Http
to support the documentation references
src/Http/Routing/src/Builder/RoutingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…xtensions.cs Co-authored-by: Copilot <[email protected]>
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Include a warning about host spoofing in xml
Summary of the changes
Adds remarks for warning about host spoofing
Changes taken from previously unmerged PR #54971
Description
Update API remarks for RoutingEndpointConventionBuilderExtensions.RequireHost to warn about host spoofing
This is how it looks like in VS code after changes. Idk why crefs are not rendered properly in VS code.
Fixes #48818