Avoid having a separate global.json for template tests #63386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
the
area-infrastructure
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of having duplicate .NET version definitions by consolidating the global.json configuration. Instead of maintaining separate global.json files for template tests, it copies the main global.json to the templates location and updates the .NET root path structure.
- Updated the template test .NET root path from
dotnet\to.dotnet\to align with the new global.json paths configuration - Added copying of the main global.json file to the template test infrastructure
- Enhanced global.json with SDK paths and error message configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ProjectTemplates/TestInfrastructure/PrepareForTest.targets | Updates .NET root path and adds global.json copying mechanism |
| global.json | Adds SDK paths configuration and error messaging for missing .NET SDK |
ilonatommy
force-pushed
the
brecon/paths-follow-up
branch
from
8449526 to
f10fe1e
Compare
wtgodbe
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #62619.
We want to avoid having the dotnet version defined in multiple places. We can use the mechanism of copying the main
global.jsonto templates location, just making sure the destination path is correct.