Unquarantine RadioButtonGetsResetAfterSubmittingEnhancedForm
#63556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR unquarantines two E2E tests that were previously failing on net8 but now have a 100% pass rate on net9. The changes remove the [QuarantinedTest] attributes and replace synchronous assertions with WaitAssert calls for better reliability in the form handling test.
- Removes quarantine status from two E2E tests that are now stable
- Updates form handling test to use
WaitAssertinstead of synchronous assertions for better reliability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| FormWithParentBindingContextTest.cs | Removes quarantine attribute and replaces Assert calls with WaitAssert for radio button form test |
| EnhancedNavigationTest.cs | Removes quarantine attribute from navigation manager URI update test |
ilonatommy
added
area-blazor
javiercn
approved these changes
Sep 5, 2025
|
|
ilonatommy
changed the title
NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly and RadioButtonGetsResetAfterSubmittingEnhancedFormRadioButtonGetsResetAfterSubmittingEnhancedForm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating failures from #63534, I found out that these issues that fail on net8 have 100% pass rate on net9. They can be enabled.
Issues that they refer to are resolved for main. On main we added
WaitAssertin the place that was reported originally as failing. We can backport that change as well.