Revert "[test-quarantine] Quarantine flaky RedirectionTest.RedirectEnhancedNonBlazorGetToExternal" - #69089
Open
ilonatommy wants to merge 1 commit into
Open
Conversation
…hancedNo…" This reverts commit a20ceae.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted revert (attribute removal only) with no apparent behavioral or structural risks beyond re-enabling the test.
Pull request overview
This PR reverts the earlier test-quarantine change that marked RedirectionTest.RedirectEnhancedNonBlazorGetToExternal as quarantined, returning the test to normal execution now that the underlying flakiness is believed to be addressed by prior fixes.
Changes:
- Removes the
[QuarantinedTest(...)]attribute fromRedirectEnhancedNonBlazorGetToExternal.
File summaries
| File | Description |
|---|---|
| src/Components/test/E2ETest/ServerRenderingTests/RedirectionTest.cs | Un-quarantines a specific external redirection E2E theory by removing its quarantine attribute. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #68946. The failures should be fixed since #68782 and the 2 builds quoted in quarantine PR were from 13th August and even older (details got already deleted by now). Not sure if the
no-quarantinelabel works on a merged PR, maybe we will have to re-label it once the bot reports it broken again.I don't understand "has never carried a [QuarantinedTest] attribute before" in the bot's PR, when we can see that https://github.com/dotnet/aspnetcore/pull/68782/changes has
Do I read something wrong?
Also, #68849 carries the
no-quarantinelabel and the bot got triggered anyway.