Skip to content

[release/11.0] Move BasePath into Components - #69143

Open
github-actions[bot] wants to merge 2 commits into
release/11.0from
backport/pr-69117-to-release/11.0
Open

[release/11.0] Move BasePath into Components#69143
github-actions[bot] wants to merge 2 commits into
release/11.0from
backport/pr-69117-to-release/11.0

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Move BasePath into Components

BasePath is a new component (public API) introduced in .NET 11 Preview 1. It was put in the wrong namespace.

Description

We added BasePath in #64590, but it requires users to pay attention to the namespaces they imported and add an additional @using.

Fixes #69115

Customer Impact

The change makes it for a more friendly usage of a new component that we added in .NET 11.

Regression?

No

Risk

Low.

BasePath is a new component in .NET 11 and the change here is just the namespace.

Verification

No verification needed. This is a public API change.

Packaging changes reviewed?

N/A

* Initial plan

* Move BasePath to Components.Web and clean imports

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

* Keep BasePath in Endpoints with Web namespace only

Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
@github-actions
github-actions Bot requested a review from a team as a code owner September 8, 2026 15:50
Comment thread src/Components/Endpoints/src/Routing/BasePath.cs Outdated
@ilonatommy ilonatommy changed the title [release/11.0] Move BasePath into Components.Web [release/11.0] Move BasePath into Components Sep 8, 2026
Comment thread src/Components/Endpoints/src/Routing/BasePath.cs Outdated
Comment thread src/Components/Endpoints/src/PublicAPI.Unshipped.txt Outdated
Comment thread src/Components/Endpoints/test/Routing/BasePathTest.cs Outdated
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>

@Youssef1313 Youssef1313 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Youssef1313 Youssef1313 added the Servicing-consider Shiproom approval is required for the issue label Sep 8, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@ilonatommy
ilonatommy requested a review from artl93 September 8, 2026 16:46

@artl93 artl93 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature. Quality. Approved.

@artl93 artl93 added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 8, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants