[DirectTLS] exclude experimental transport from release 11 - #69144
Open
DeagleGross wants to merge 3 commits into
Open
[DirectTLS] exclude experimental transport from release 11#69144DeagleGross wants to merge 3 commits into
DeagleGross wants to merge 3 commits into
Conversation
…ead (dotnet#68664)" This reverts commit 49e0516. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…)" This reverts commit 07d11eb. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
DeagleGross
added
the
area-networking
DeagleGross
changed the title
DeagleGross
marked this pull request as ready for review
September 9, 2026 08:47
DeagleGross
requested review from
a team,
BrennanConroy,
SamMonoRT,
halter73,
tdykstra and
wtgodbe
as code owners
September 9, 2026 08:47
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
An unused using Moq; in an updated test file can trigger IDE0005 under enforced code-style analysis and break the build.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/Servers/Kestrel/test/Sockets.BindTests/SocketTransportFactoryTests.cs — using Moq; is unused in this test file. With code-style analysis enabled in this repo, unused… |
What changed in this PR
This PR removes the experimental DirectTLS Kestrel transport and its associated endpoint types from the repo’s release-11 surface area, including build/shipping registration, tests, and samples (related to #65303).
Changes:
- Remove the
Transport.DirectTlstransport implementation, its unit tests, and the DirectTls sample app. - Remove
DirectTlsEndpoint/DirectTlsEndpointOptionsfromKestrel.Corepublic API tracking and assembly internals exposure. - Clean up sockets transport code/tests to drop DirectTLS-specific binding behavior and dependencies.
| File | Description |
|---|---|
| src/Servers/Kestrel/Transport.Sockets/src/SocketTransportFactory.cs | Removes DirectTLS endpoint exclusion logic from sockets transport binding. |
| src/Servers/Kestrel/Transport.Sockets/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj | Drops DirectTLS warning suppression and Core reference that existed only for DirectTLS endpoint checks. |
| src/Servers/Kestrel/Transport.DirectTls/test/WebHostBuilderDirectTlsExtensionsTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/TlsEventPumpStopTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/TlsEventPumpHandshakeTimeoutTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/TlsEventPumpHandshakeInterestTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/TlsEventPumpConnectionDropTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/TlsEventPumpAcceptTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/TestHostApplicationLifetime.cs | Removes DirectTLS test helper (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/Microsoft.AspNetCore.Server.Kestrel.Transport.DirectTls.Tests.csproj | Removes DirectTLS test project (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/EpollInteropTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsUserCallbackDispatchTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsTransportFactoryTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsListenerDisposalTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsHandshakeLimitSetupTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsEndpointTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsContextResolverFastPathTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsConnectionListenerFatalErrorTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/DirectTlsConnectionDisposeTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/ConnectionTrackerTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/test/ClientCertificateValidatorTests.cs | Removes DirectTLS test coverage (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/WebHostBuilderDirectTlsExtensions.cs | Removes public hosting extension surface for DirectTLS registration (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/UserCallbacks/ValidateClientCertificateCallback.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/UserCallbacks/ResolveTlsContextCallback.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/UserCallbacks/HandshakeUserCallback.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/TlsException.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/TlsEventPumpPool.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/TlsEventPump.UserCallbacks.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/TlsAwaitable.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/ServerTlsContexts.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/PublicAPI.Unshipped.txt | Removes DirectTLS transport public API baseline entries (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/PublicAPI.Shipped.txt | Removes DirectTLS transport shipped API baseline file (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/Microsoft.AspNetCore.Server.Kestrel.Transport.DirectTls.csproj | Removes DirectTLS transport project (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/Interop/NativeTls.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/Interop/Models.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/DirectTlsTransportOptions.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/DirectTlsTransportFactory.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/DirectTlsHandshakeLimitSetup.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/DirectTlsEndpointProtocolsSetup.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/ConnectionTracker.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/ConnectionIoState.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/Connection/DirectTlsConnectionListener.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/Connection/DirectTlsConnection.FeatureCollection.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/Connection/DirectTlsConnection.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/Transport.DirectTls/src/ClientCertificateValidator.cs | Removes DirectTLS implementation (file deleted). |
| src/Servers/Kestrel/test/Sockets.BindTests/SocketTransportFactoryTests.cs | Removes DirectTLS-specific bind tests; updates usings. |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/scripts/wrk-load.sh | Removes DirectTLS sample assets (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/scripts/openssl-request.sh | Removes DirectTLS sample assets (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/scripts/generate-certs.sh | Removes DirectTLS sample assets (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/scripts/curl-request.sh | Removes DirectTLS sample assets (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/scripts/close-connection.lua | Removes DirectTLS sample assets (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/README.md | Removes DirectTLS sample documentation (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/Program.cs | Removes DirectTLS sample app entry point (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/DirectTlsTransportApp.csproj | Removes DirectTLS sample project (file deleted). |
| src/Servers/Kestrel/samples/DirectTlsTransportApp/.gitignore | Removes DirectTLS sample gitignore entries (file deleted). |
| src/Servers/Kestrel/Kestrel.slnf | Removes DirectTLS projects/sample from Kestrel solution filter. |
| src/Servers/Kestrel/Core/src/PublicAPI.Unshipped.txt | Removes DirectTls endpoint/options API entries from Kestrel.Core baseline tracking. |
| src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj | Removes DirectTLS experimental warning suppression and InternalsVisibleTo for DirectTls. |
| src/Servers/Kestrel/Core/src/DirectTlsEndpointOptions.cs | Removes DirectTls endpoint options type (file deleted). |
| src/Servers/Kestrel/Core/src/DirectTlsEndpoint.cs | Removes DirectTls endpoint type (file deleted). |
| eng/TrimmableProjects.props | Removes DirectTLS transport from trimmable projects list. |
| eng/ShippingAssemblies.props | Removes DirectTLS transport from shipping assemblies list. |
| eng/ProjectReferences.props | Removes DirectTLS transport from project reference provider list. |
| AspNetCore.slnx | Removes DirectTLS projects/sample from the repo solution definition. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
BrennanConroy
approved these changes
Sep 9, 2026
BrennanConroy
left a comment
BrennanConroy
left a comment
Member
There was a problem hiding this comment.
Looks good, but remove using Moq
DeagleGross
commented
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #65303