Run dojo scenarios against AG-UI and direct IChatClient - #69167
Draft
dariatiurina wants to merge 3 commits into
Draft
Run dojo scenarios against AG-UI and direct IChatClient#69167dariatiurina wants to merge 3 commits into
dariatiurina wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run dojo scenarios against AG-UI and direct IChatClient
Description
Give the dojo's direct
IChatClientpath the same scenario coverage as its AG-UI path, without duplicating pages or test bodies. A test author writes one scenario page and one E2E test, parameterized to run against both backends.Changes
DOJO_BACKEND=AGUI(default) orDOJO_BACKEND=Direct. AG-UI usesAGUIDojoApiover HTTP/SSE; Direct runs the model in the DojoClient process without that transport.DojoAgenttest-asset library, referenced by both hosts.Selection happens when each app starts, not between requests in a running app. Direct E2E hosts use an unreachable AG-UI URL so an accidental transport dependency cannot silently reach another server. Native tool results are compared using the recordings' JSON representation, retaining the same expected values.
Testing
Parameterize all 15 existing dojo browser tests with AGUI and Direct data rows, producing 30 cases from the same test bodies. Coverage includes incremental streaming, rich text, multi-turn history, client-tool circuit isolation, server-tool rendering, approval and rejection, generative UI, shared state, predictive edit acceptance/rejection, and responsive controls.
Breaking changes
None to shipping framework APIs. AG-UI remains the default. The separate
AIAppand its tests are unchanged; this PR adds direct-backend coverage to the dojo rather than merging or removing AIApp.Fixes #69166