Repository navigation
Update the Components.Platform porting skill with rules settled by Cookie Store - #69989
jsakamotoIGJP wants to merge 7 commits into
Conversation
… the E2E result marker
|
Thanks for your PR, @jsakamotoIGJP. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
|
@ilonatommy This is the follow-up to the porting skill (#69829). It turns the two rules you settled on the Cookie Store proposal ( |
There was a problem hiding this comment.
🔵 Needs a closer look
The required frozen review bundle was unavailable, so the prescribed approval checks remain incomplete.
No open issues 🎉
What changed in this PR
This PR updates the Components.Platform porting skill to reflect decisions settled by Cookie Store, without changing product code.
Changes:
- Establishes
ASP0040andNotSupportedExceptionas fixed porting rules. - Adds Cookie Store references and completion-counter guidance for E2E steps.
- Adds three evaluation stimuli covering the newly documented rules.
| File | Description |
|---|---|
eng/skill-evals/port-components-platform-api/eval.vally.yaml |
Adds evaluations for experimental members, missing browser objects, and E2E result tracking. |
.github/skills/port-components-platform-api/SKILL.md |
Codifies settled rules and adds Cookie Store reference patterns. |
.github/skills/port-components-platform-api/references/type-mapping.md |
Marks the example Partitioned property experimental with ASP0040. |
Review effort: Balanced
| - The PublicAPI.Unshipped.txt lines for the experimental member have no diagnostic ID prefix. | ||
| - The ASP0040 warning is suppressed only around the code that uses the experimental member, not for a whole project with NoWarn. | ||
| - The answer does not treat the experimental marking itself as an unresolved open question that blocks the design. | ||
| - Callers reach the family through a synchronous Screen extension property on Window, and the other attributes become GetWidthAsync, GetHeightAsync, and GetColorDepthAsync with int, int, and uint results. |
There was a problem hiding this comment.
Agent review: Could we add Web IDL long → C# int to references/type-mapping.md? This rubric requires that mapping, but the reference currently documents only unsigned long and long long. Without it, this case partly tests prior Web IDL knowledge rather than the skill.
Vally 0.19.0 removed constraints.reject_tools (dotnet#69995). Use the same disallowed list as the other stimuli.
Update the porting skill with rules settled by Cookie Store
Description
This PR updates the
port-components-platform-apiskill (#69829). It does not change any product code.When the skill was merged, two rules were still open, so the skill told the agent to stop and ask. Both were settled in the review of the Cookie Store API proposal (#69844), and Cookie Store (#69845) is now in
main. This PR turns them into fixed rules and points the agent at Cookie Store as a second example.[Experimental]for members that are not Baseline. The skill said that the package had no diagnostic ID yet. Now it tells the agent to useASP0040with the sameUrlFormatasASP0039, never to allocate a new ID, and to suppress the warning with#pragmain tests and demo pages. TheCookieInitexample intype-mapping.mdnow has the attribute onPartitioned, as in the real code.NotSupportedExceptionfor a missing browser object. The skill called it a proposed default and told the agent to raise it as an open question. Now it is a fixed rule.data-runcounter thatCookieStoreTestsuses, so a step cannot pass on the text of the previous step.Skill eval
I added three stimuli to
eng/skill-evals/port-components-platform-api/eval.vally.yaml, one for each new rule. They cover a member that is not Baseline, a missing browser object, and E2E steps that expect the same text as an earlier step. I ran the smoke experiment locally (one trial per stimulus). The skilled variant passed all 8 stimuli, and the baseline passed none.Contributes to #69987