Add Windows Desktop Runtime support to dotnet-core-uninstall #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool was not detecting or uninstalling
Microsoft.WindowsDesktop.Appruntimes, leaving them behind after cleanup operations.Changes
Type System
WindowsDesktopRuntime = 0x10toBundleTypeenumWindowsDesktopRuntimeVersionclass following existing runtime patternsDetection
RegistryQuery.GetBundleVersion()to detect Windows Desktop Runtime before falling through to generic RuntimeCLI
--windows-desktop-runtimeoption for list/remove/dry-run commandsLocalization
Tests
WindowsDesktopRuntimeVersionTestswith version parsing, equality, and comparison testsRegistryQueryTestsUsage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
1p7vsblobprodcus324.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet restore lab.sln(dns block)1s1vsblobprodcus386.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet restore lab.sln(dns block)2kmvsblobprodcus39.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/46EB19D8E6D150879BD3367A72FC2FBC/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)4myvsblobprodcus32.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/5A662EEFB2568432D6FDBE7CF1D19C8E/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)51yvsblobprodcus36.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet restore lab.sln(dns block)7tjvsblobprodcus341.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet build ./src/dotnet-core-uninstall/dotnet-core-uninstall.csproj(dns block)d0svsblobprodcus381.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/FA6DB83614BF5C5211016F7FB850878E/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)jrqvsblobprodcus343.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/AB3F5B4F38F39326F517C95985BB1CCD/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)k0ivsblobprodcus356.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet restore lab.sln(dns block)o3svsblobprodcus318.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/307E99119043270B829736F32461490F/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)pe4vsblobprodcus351.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet restore lab.sln(dns block)pkvvsblobprodcus321.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/0C0F71666708895B0B68BA9B320DB87D/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)rcxvsblobprodcus328.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet restore lab.sln(dns block)s8mvsblobprodcus38.vsblob.vsassets.iodotnet build lab.sln(dns block)dotnet restore lab.sln --force-evaluate(dns block)dotnet restore lab.sln(dns block)sc4vsblobprodcus331.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/0A4E58E778FC4449F6B50463EA93DD88/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)securitytools.pkgs.visualstudio.com/opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp(dns block)sqdvsblobprodcus333.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/820A97C1134D984973320EFFC6EC43BE/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)st8vsblobprodcus339.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/1547C205BD65A89A30F6427AD94CC555/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)u3hvsblobprodcus371.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/71CDA9FA07BF67921CD59B3ABBA37B0E/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)yttvsblobprodcus357.vsblob.vsassets.iodotnet restore --no-dependencies /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/C66EB009B13635B85A56934286C57648/missingpackages_workingdir --packages /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli-lab/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>Desktop-runtime?</issue_title>
<issue_description>Seems to have left stuff behind. Is it not possible to also handle Microsoft.WindowsDesktop.App?
FYI rg is installed by
choco upgrade ripgrep -y