-
Notifications
You must be signed in to change notification settings - Fork 6k
Add explanation for contravariance behavior with anonymous functions #47707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
August 1, 2025 19:44
BillWagner
reviewed
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, and this is ready.
...e/concepts/covariance-contravariance/using-variance-for-func-and-action-generic-delegates.md
Outdated
Show resolved
Hide resolved
The var keyword represents implicit typing, not explicit typing. This correction addresses the terminology issue pointed out in the code review. Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
August 4, 2025 18:01
BillWagner
reviewed
Aug 4, 2025
...e/concepts/covariance-contravariance/using-variance-for-func-and-action-generic-delegates.md
Outdated
Show resolved
Hide resolved
Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
August 4, 2025 18:17
BillWagner
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now ready for final review.
gewarren
approved these changes
Aug 4, 2025
...e/concepts/covariance-contravariance/using-variance-for-func-and-action-generic-delegates.md
Outdated
Show resolved
Hide resolved
...e/concepts/covariance-contravariance/using-variance-for-func-and-action-generic-delegates.md
Outdated
Show resolved
Hide resolved
...e/concepts/covariance-contravariance/using-variance-for-func-and-action-generic-delegates.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
advanced-concepts/subsvc
dotnet-csharp/svc
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a counterintuitive behavior with lambda expressions and delegate contravariance that was causing confusion for C# developers.
The Problem
The existing documentation explained contravariance well for named methods, but didn't cover why this seemingly equivalent code behaves differently:
The Solution
Added a new section "Contravariance and Anonymous Functions" that explains:
(Person p) => p.ReadContact()
should have typeAction<Person>
when being assigned toAction<Employee>
The new documentation includes complete code examples that demonstrate both the problem and the solutions, helping developers understand this subtle but important compiler behavior.
Fixes #31678.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Internal previews