[msbuild] Fix building apps with extensions remotely. #23509

rolfbjarne · 2025-08-06T16:32:12Z

Pending: the actual fixes.

For now this only has a test.

Fixes #23516.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.

Pending: the actual fix. For now this only has a test. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.

…ns. Fixes #23516. Don't override the GetTargetPath/Build/Rebuild targets for app extensions, because we also override some of these targets when building remotely, and the custom logic for app extensions is overridden. Instead create new targets that depend on those we previously override instead. Fixes #23516.

Always run WriteItemsFromFile locally, as these operations just read/write items from/to an XML file, this is something we don't need to run remotely when building from Windows. This improves the build performance and also fixes some inconsistencies we had were sometimes files were written locally and read remotely (or the other way around). This means we need to adjust any corresponding ReadItemsFromFile calls accordingly. It also allows us to remove the remoting support in WriteItemsFromFile, but we can't remove remoting support for ReadItemsFromFile, because sometimes we have to read files that aren't written with WriteItemsFromFile (they're written by other tasks).

vs-mobiletools-engineering-service2 · 2025-10-31T18:30:52Z

✅ [PR Build #dc2a090] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T18:47:12Z

✅ [CI Build #dc2a090] Build passed (Build packages) ✅

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T18:58:37Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T19:23:20Z

✅ [CI Build #dc2a090] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T19:40:37Z

💻 [CI Build #dc2a090] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T19:47:25Z

💻 [CI Build #dc2a090] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T19:50:19Z

💻 [CI Build #dc2a090] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T19:50:33Z

💻 [CI Build #dc2a090] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T19:55:01Z

💻 [CI Build #dc2a090] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-31T20:45:54Z

🔥 [CI Build #dc2a090] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 3 tests failed, 110 tests passed.

Failures

❌ interdependent-binding-projects tests

1 tests failed, 3 tests passed.

interdependent-binding-projects/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ windows tests

1 tests failed, 0 tests passed.

Html Report (VSDrops) Download

❌ xcframework tests

1 tests failed, 3 tests passed.

xcframework-test/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dc2a09057322519ba5443e20e1229cadeb455cf2 [PR build]

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits October 31, 2025 17:03

[msbuild] Fix building apps with extensions remotely.

db7c679

Pending: the actual fix. For now this only has a test. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.

rolfbjarne force-pushed the dev/rolf/fix-building-extensions-on-remote-windows branch from 2b0f82f to bf94754 Compare October 31, 2025 16:18

rolfbjarne changed the base branch from net10.0 to main October 31, 2025 16:30

emaf and others added 2 commits October 31, 2025 17:38

Update IsRemoteBuild

dc2a090

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the dev/rolf/fix-building-extensions-on-remote-windows branch from bf94754 to dc2a090 Compare October 31, 2025 17:56

[msbuild] Fix building apps with extensions remotely. #23509

Are you sure you want to change the base?

[msbuild] Fix building apps with extensions remotely. #23509

Uh oh!

Conversation

rolfbjarne commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 31, 2025

✅ [PR Build #dc2a090] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

✅ [CI Build #dc2a090] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

✅ [CI Build #dc2a090] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

💻 [CI Build #dc2a090] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

💻 [CI Build #dc2a090] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

💻 [CI Build #dc2a090] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

💻 [CI Build #dc2a090] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 31, 2025

💻 [CI Build #dc2a090] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

rolfbjarne commented Aug 6, 2025 •

edited

Loading